make link handler API public #2169
Conversation
jckautzmann
commented
May 17, 2022
jckautzmann
commented
- draft API
| Q | A |
|---|---|
| Fixed Issues? | Fixes #2168 |
| Patch: Bug Fix? | |
| Minor: New Feature? | |
| Major: Breaking Change? | |
| Tests Added + Pass? | No |
| Documentation Provided | No |
| Any Dependency Changes? | |
| License | Apache License, Version 2.0 |
- draft API
- draft API
Codecov Report
@@ Coverage Diff @@
## main #2169 +/- ##
=========================================
Coverage 86.86% 86.86%
Complexity 2376 2376
=========================================
Files 214 214
Lines 6358 6358
Branches 965 965
=========================================
Hits 5523 5523
Misses 332 332
Partials 503 503 Continue to review full report at Codecov.
|
- draft API
- draft API
- draft API
- draft API
|
Kudos, SonarCloud Quality Gate passed!
|
| import com.adobe.cq.wcm.core.components.commons.link.Link; | ||
| import com.day.cq.wcm.api.Page; | ||
|
|
||
| public interface LinkHandler { |
| */ | ||
| @NotNull | ||
| @SuppressWarnings("rawtypes") | ||
| Optional<Link> getLink(@NotNull Resource resource, String linkURLPropertyName, Map<String, String> attributes); |
There was a problem hiding this comment.
Remove the Optional and throw exception in case a Link cannot be constructed
| */ | ||
| @NotNull | ||
| @SuppressWarnings("rawtypes") | ||
| Optional<Link> getLink(@Nullable Page page, Map<String, String> attributes); |
There was a problem hiding this comment.
Remove the Optional and throw exception in case a Link cannot be constructed
| */ | ||
| @NotNull | ||
| @SuppressWarnings("rawtypes") | ||
| Optional<Link> getLink(@Nullable String linkURL, Map<String, String> attributes); |
There was a problem hiding this comment.
Remove the Optional and throw exception in case a Link cannot be constructed
|
Superseded by #2196 |
