Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing flaky test #1312

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Fixing flaky test #1312

merged 3 commits into from
Jul 11, 2024

Conversation

rismehta
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 88 96 100 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

1 similar comment
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.73%. Comparing base (5b43371) to head (e29654a).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1312   +/-   ##
=========================================
  Coverage     81.73%   81.73%           
  Complexity      853      853           
=========================================
  Files            97       97           
  Lines          2267     2267           
  Branches        305      305           
=========================================
  Hits           1853     1853           
  Misses          255      255           
  Partials        159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rismehta rismehta merged commit 3971c05 into dev Jul 11, 2024
10 checks passed
@rismehta rismehta deleted the flaky7 branch July 11, 2024 03:55
rismehta added a commit that referenced this pull request Jul 11, 2024
* Fixing flaky test

* updating quickstart docker

* Fixing flaky test
rismehta added a commit that referenced this pull request Jul 11, 2024
* Fixing flaky test

* updating quickstart docker

* Fixing flaky test
devgurjar pushed a commit that referenced this pull request Jul 11, 2024
* Fixing flaky test

* updating quickstart docker

* Fixing flaky test
github-actions bot pushed a commit that referenced this pull request Jul 11, 2024
* Fixing flaky test

* updating quickstart docker

* Fixing flaky test
devgurjar pushed a commit that referenced this pull request Jul 12, 2024
* Fixing flaky test

* updating quickstart docker

* Fixing flaky test
github-actions bot pushed a commit that referenced this pull request Jul 12, 2024
* Fixing flaky test

* updating quickstart docker

* Fixing flaky test
dmaurya929 pushed a commit that referenced this pull request Jul 24, 2024
* Fixing flaky test

* updating quickstart docker

* Fixing flaky test
devgurjar pushed a commit that referenced this pull request Sep 4, 2024
* Fixing flaky test

* updating quickstart docker

* Fixing flaky test
kum-sushil pushed a commit to kum-sushil/aem-core-forms-components that referenced this pull request Jan 14, 2025
* Fixing flaky test

* updating quickstart docker

* Fixing flaky test
kum-sushil pushed a commit to kum-sushil/aem-core-forms-components that referenced this pull request Jan 14, 2025
* Fixing flaky test

* updating quickstart docker

* Fixing flaky test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants