Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1645 - Teaser component must retrieve category url_path #421

Merged
merged 4 commits into from
Oct 16, 2020

Conversation

mhaack
Copy link
Contributor

@mhaack mhaack commented Oct 13, 2020

Description

Teaser component must retrieve the category url_path for correct SEO url rendering.

Before: generated category page URLs are like .../content/venia/us/en/products/category-page.28.html/
After: generated category page URLs are like /content/venia/us/en/products/category-page.28.html/venia-bottoms or /content/venia/us/en/c/venia-bottoms.28.html (depends on URL provider config)

Related Issue

CIF-1645

Motivation and Context

Fix teaser component links to category pages.

How Has This Been Tested?

Added & extended unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #421 into master will decrease coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #421      +/-   ##
============================================
- Coverage     85.92%   85.89%   -0.03%     
- Complexity     1016     1022       +6     
============================================
  Files           208      209       +1     
  Lines          5221     5233      +12     
  Branches        743      747       +4     
============================================
+ Hits           4486     4495       +9     
  Misses          591      591              
- Partials        144      147       +3     
Flag Coverage Δ Complexity Δ
#integration 67.71% <41.66%> (-0.34%) 760.00 <3.00> (ø)
#jest 81.69% <ø> (ø) 0.00 <ø> (ø)
#karma 93.94% <ø> (ø) 0.00 <ø> (ø)
#unittests 86.01% <88.88%> (-0.02%) 990.00 <10.00> (+7.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../internal/models/v1/teaser/CommerceTeaserImpl.java 89.79% <84.00%> (-4.49%) 14.00 <4.00> (+4.00) ⬇️
...internal/models/v1/teaser/CategoriesRetriever.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)
...nal/models/v1/teaser/CommerceTeaserActionItem.java 100.00% <100.00%> (ø) 3.00 <2.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdfa40...2c45987. Read the comment docs.

@mhaack mhaack added To Verify enhancement New feature or request labels Oct 13, 2020
@cjelger cjelger merged commit 3d38d1e into master Oct 16, 2020
@cjelger cjelger deleted the issues/cif-1645 branch October 16, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants