-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1630 - Configurable header tag for teaser and carousel components #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add title tag selection for product carousel
- add title tag selection for related products
- add title tag type selection for featured category list component
- only commit real changes
- revert formatting changes
- remove inheritance with TitleTypeProvider as it would prevent sling models to extend other models
Merged
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
============================================
- Coverage 86.28% 86.27% -0.01%
- Complexity 950 954 +4
============================================
Files 198 199 +1
Lines 5053 5058 +5
Branches 729 729
============================================
+ Hits 4360 4364 +4
- Misses 551 552 +1
Partials 142 142
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
herzog31
approved these changes
Sep 30, 2020
dplaton
approved these changes
Sep 30, 2020
mhaack
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the
Title
component from the WCM components, this PR makes it possible to configure the HTML tag for the title element of theProductCarousel
,RelatedProducts
, andFeaturedCategoryList
components. Note that we do not need this for theCommerceTeaser
because this feature already exists in the WCMTeaser
parent component.This PR makes it possible to:
To avoid duplicating the dialog part for the
cq:design_dialog
configuration, the PR adds a generic field element atapps/core/cif/components/authoring/dialog/titletypetab/titletypes
similar to what is being done for thestyletab
field.Related PR
adobe/aem-cif-guides-venia#66
How Has This Been Tested?
Extended unit tests.
Screenshots (if appropriate):
Types of changes
Checklist: