-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1609 - Lazy Loading for PLP #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement lazy loading for productcollection component
- add design dialog option to choose pagination type
- enable lazy loading for search results component
- display/hide loading spinner when loading more products
- add unit tests
- add client-side fetching of lazy loaded products
- update README files
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
============================================
+ Coverage 86.06% 86.11% +0.05%
- Complexity 947 950 +3
============================================
Files 188 188
Lines 4886 4918 +32
Branches 696 697 +1
============================================
+ Hits 4205 4235 +30
- Misses 539 541 +2
Partials 142 142
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
- extend unit test
- make sure the 'lazy' selector is not added multiple times
herzog31
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds lazy loading to the category and search pages vis the
productcollection
component. The pages are still rendered on the server, and are requested with a "load more" button and then appended to the display by some JS code.See the screenshots: configuring the component to lazy-load adds a "Load more" button, clicking it displays a loading spinner until the next page is loaded.
The css changes are in adobe/aem-cif-guides-venia#61
How Has This Been Tested?
Extended unit tests and tested manually.
Screenshots (if appropriate):
Types of changes
Checklist: