Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1644 - GraphQL requests for staged data should use POST #403

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Sep 23, 2020

This is a workaround to ensure that Magento does not return a cached response for staged data.

How Has This Been Tested?

Manually tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@cjelger cjelger added the bug Something isn't working label Sep 23, 2020
@cjelger cjelger requested review from mhaack and herzog31 September 23, 2020 06:57
@cjelger
Copy link
Contributor Author

cjelger commented Sep 23, 2020

@mhaack @herzog31 As discussed yesterday, let's use POST so we don't have any issue with Magento caching. I created CIF-1644 and also linked the related Magento issue.

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #403 into master will increase coverage by 9.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #403      +/-   ##
============================================
+ Coverage     75.73%   85.34%   +9.61%     
- Complexity      697      932     +235     
============================================
  Files           186      186              
  Lines          4859     4860       +1     
  Branches        690      692       +2     
============================================
+ Hits           3680     4148     +468     
+ Misses          959      563     -396     
+ Partials        220      149      -71     
Flag Coverage Δ Complexity Δ
#integration 67.38% <0.00%> (-0.03%) 687.00 <0.00> (ø)
#jest 81.04% <ø> (ø) 0.00 <ø> (ø)
#karma 94.32% <ø> (ø) 0.00 <ø> (ø)
#unittests 85.79% <100.00%> (-7.36%) 870.00 <0.00> (+830.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...e/core/components/client/MagentoGraphqlClient.java 70.58% <100.00%> (+36.25%) 12.00 <0.00> (+8.00)
...ommerce/core/examples/servlets/GraphqlServlet.java 75.34% <0.00%> (-17.81%) 30.00% <0.00%> (-10.00%)
...ervices/ComponentsConfigurationAdapterFactory.java 63.63% <0.00%> (ø) 3.00% <0.00%> (ø%)
...e/search/internal/models/SearchResultsSetImpl.java 84.61% <0.00%> (+2.56%) 27.00% <0.00%> (+1.00%)
...rch/internal/services/SearchFilterServiceImpl.java 70.21% <0.00%> (+4.25%) 14.00% <0.00%> (+2.00%)
...nternal/models/v1/productlist/ProductListImpl.java 95.58% <0.00%> (+4.41%) 26.00% <0.00%> (+3.00%)
.../search/internal/models/SearchAggregationImpl.java 96.66% <0.00%> (+6.66%) 16.00% <0.00%> (+2.00%)
...h/internal/models/FilterAttributeMetadataImpl.java 100.00% <0.00%> (+7.69%) 9.00% <0.00%> (+1.00%)
...h/internal/models/SearchAggregationOptionImpl.java 100.00% <0.00%> (+7.69%) 9.00% <0.00%> (+1.00%)
...s/internal/models/v1/product/ProductRetriever.java 100.00% <0.00%> (+8.00%) 34.00% <0.00%> (+3.00%)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a919ec9...049bc4c. Read the comment docs.

@herzog31 herzog31 merged commit 46469c2 into master Sep 23, 2020
@herzog31 herzog31 deleted the CIF-1644 branch September 23, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants