-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1469 - CIF Core Components support for staged catalog data #399
Conversation
- added support for AEM Launches in magento client - adapted components and unit tests to support launches
- adapted navigation and breadcrumb components to work with Launches - extended site navigation methods to find product, category, and search pages in Launches - extended unit tests for the site navigation with Launches
- ensures that product and category specific pages are properly detected in breadcrumb on launch pages - extended unit tests
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
============================================
- Coverage 76.11% 73.41% -2.70%
+ Complexity 698 697 -1
============================================
Files 186 176 -10
Lines 4789 4315 -474
Branches 669 681 +12
============================================
- Hits 3645 3168 -477
+ Misses 931 927 -4
- Partials 213 220 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
- revert coverage checks introduces by #398
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. What about the client-side code?
@herzog31 Good point, I'll create a follow-up issue for that and add it for technical grooming. |
This PR adds the support for staged catalog data for Magento and AEM Launches. If the current page is inside an AEM Launch, a
Preview-Version
HTTP header will be sent with all GraphQL requests. The "epoch" value of the header is taken from the live date of the AEM Launch.This also requires that a Magento integration token (with permission "Catalog > Staging") must be configured as an
Authorization:Bearer <token>
HTTP header in the GraphQL client.Also important: I adapted the navigation and breadcrumb components so they use the "production version" of the current page to get their configuration, an also adapted the
SiteNavigation
class to make sure that it creates the "correct" links for the product and category pages. Here "correct" means that if the Launch includes the product and/or category page(s), then the links should point to the pages from the Launch and not to production pages.How Has This Been Tested?
Extended unit tests and extensively tested manually.
Types of changes
Checklist: