CIF-1624: Remove commons-text dependency in UrlProviderImpl #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbacila
requested review from
cjelger,
herzog31,
mhaack,
laurentiumagureanu and
LSantha
mhaack
reviewed
Sep 9, 2020
| @@ -162,4 +161,24 @@ private String parseIdentifier(IdentifierLocation identifierLocation, SlingHttpS | |||
| throw new RuntimeException("Identifier location " + identifierLocation + " is not supported"); | |||
| } | |||
| } | |||
|
|
|||
| static class StringSubstitutor { | |||
There was a problem hiding this comment.
Instead of inventing our own new class can't we just use https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html#replaceEach-java.lang.String-java.lang.String:A-java.lang.String:A- ? This bundle is already available in AEM.
Or as alternative use a regex?
There was a problem hiding this comment.
Our StringSubstitutor:replace method uses just that (StringUtils.replaceEach). Our own StringSubstituor was created to preserve the UrlProviderImpl implementation.
There was a problem hiding this comment.
I saw we use StringUtils.replaceEach, wonder if that also can be done simpler? Mabe with String.formart() or RegEx. But I'm just nitpicking here.
LSantha
approved these changes
Sep 9, 2020
herzog31
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the use of
StringSubstitutor.replace()inUrlProviderImplwithStringUtilsmethods to avoid adding dependency on Apache'scommons-textpackage.Motivation and Context
The
commons-textbundle was embedded inui.appspackage. Embedding 3rd party bundles in application type package is now prohibitted for AEM as a Cloud Service.How Has This Been Tested?
Types of changes
Checklist: