Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1590 - Remove Venia specific font from page component #384

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

herzog31
Copy link
Member

Description

  • Remove Venia specific font from page component.
  • Font was moved to the Venia project via .

How Has This Been Tested?

  • Manual

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #384 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #384   +/-   ##
=========================================
  Coverage     84.81%   84.81%           
  Complexity      924      924           
=========================================
  Files           179      179           
  Lines          4570     4570           
  Branches        614      614           
=========================================
  Hits           3876     3876           
  Misses          557      557           
  Partials        137      137           
Flag Coverage Δ Complexity Δ
#integration 68.16% <ø> (ø) 686.00 <ø> (ø)
#jest 77.29% <ø> (ø) 0.00 <ø> (ø)
#karma 94.32% <ø> (ø) 0.00 <ø> (ø)
#unittests 86.07% <ø> (ø) 892.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4d636...c99e9ad. Read the comment docs.

@dplaton dplaton merged commit 64753d2 into master Aug 28, 2020
@dplaton dplaton deleted the issue/CIF-1590 branch August 28, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants