Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1535 - Support placeholder text in searchbar component #371

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

herzog31
Copy link
Member

Description

  • Added placeholder to searchbar component. The placeholder can be changed by defining the placeholder property.
  • Updated component readme.
  • Added placeholder property to CIF component library as example.

How Has This Been Tested?

  • Manually tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the enhancement New feature or request label Aug 10, 2020
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #371 into master will decrease coverage by 10.71%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #371       +/-   ##
=============================================
- Coverage     84.50%   73.79%   -10.72%     
+ Complexity      855      631      -224     
=============================================
  Files           174      174               
  Lines          4388     4388               
  Branches        590      588        -2     
=============================================
- Hits           3708     3238      -470     
- Misses          553      954      +401     
- Partials        127      196       +69     
Flag Coverage Δ Complexity Δ
#integration 67.10% <ø> (ø) 631.00 <ø> (ø)
#jest 77.36% <ø> (ø) 0.00 <ø> (ø)
#karma 93.93% <ø> (ø) 0.00 <ø> (ø)
#unittests ? ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...s/internal/servlets/SpecificPageFilterFactory.java 0.00% <0.00%> (-90.91%) 0.00% <0.00%> (-6.00%)
...e/components/internal/servlets/PreviewServlet.java 6.66% <0.00%> (-90.00%) 2.00% <0.00%> (-6.00%)
...elatedproducts/RelationTypesDataSourceServlet.java 7.14% <0.00%> (-85.72%) 1.00% <0.00%> (-3.00%)
...ernal/servlets/GraphqlClientDataSourceServlet.java 15.38% <0.00%> (-74.36%) 3.00% <0.00%> (-4.00%)
...commerce/core/components/utils/SiteNavigation.java 30.00% <0.00%> (-50.00%) 7.00% <0.00%> (-10.00%)
...ommerce/core/search/internal/models/PagerImpl.java 44.44% <0.00%> (-50.00%) 8.00% <0.00%> (-11.00%)
...mponents/internal/models/v1/button/ButtonImpl.java 0.00% <0.00%> (-48.49%) 0.00% <0.00%> (-14.00%)
...ts/models/retriever/AbstractCategoryRetriever.java 37.50% <0.00%> (-45.00%) 6.00% <0.00%> (-8.00%)
...ls/v1/productcollection/ProductCollectionImpl.java 52.00% <0.00%> (-44.00%) 6.00% <0.00%> (-5.00%)
...l/services/GenericProductAttributeFilterInput.java 42.10% <0.00%> (-42.11%) 4.00% <0.00%> (-4.00%)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a103a...7ec267b. Read the comment docs.

@herzog31 herzog31 merged commit fdff9e9 into master Aug 12, 2020
@herzog31 herzog31 deleted the issue/CIF-1535 branch August 12, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants