-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1498 - Setup IT project for CIF components #347
Conversation
- setup basic IT project
- use new client for tests to use HTTP instead of HTTPS
- fix build issue
- add ITs for productlist and productteaser components
- add basic ITs for all components
- do not install WCM Core components with Cloud SDK
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=============================================
+ Coverage 65.63% 88.31% +22.68%
- Complexity 821 852 +31
=============================================
Files 192 80 -112
Lines 5843 2876 -2967
Branches 912 259 -653
=============================================
- Hits 3835 2540 -1295
+ Misses 1879 210 -1669
+ Partials 129 126 -3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Just noticed, but might be unrelated to this PR. The integration tests correctly report the |
- update codecov orb
- remove deprecated argument
@herzog31 I fixed the codecov flags by setting the orb to the |
@cjelger Yes that helped 👍 . All flags are available now. See for example https://codecov.io/gh/adobe/aem-core-cif-components/src/6f2142699eb5aa56e24dfe6317da4a681b58f9ba/bundles/core/src/main/java/com/adobe/cq/commerce/core/components/client/MagentoGraphqlClient.java. |
This PR adds some basic integration tests for the CIF components based on the CIF components library.
The tests are rather basic and only check that each component renders some "basic" elements like for example the product name, the products of a category, etc, without going into all the possible details. The scope of each test could be extended if needed, the main goal here is to ensure that each component properly renders and all elements (components, graphql client, etc, work together).
Note that the
it/http
project is ignored when we perform a release by setting theskip-it
Maven profile during the release.Checklist: