Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1498 - Setup IT project for CIF components #347

Merged
merged 13 commits into from
Jul 28, 2020
Merged

CIF-1498 - Setup IT project for CIF components #347

merged 13 commits into from
Jul 28, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Jul 24, 2020

This PR adds some basic integration tests for the CIF components based on the CIF components library.

The tests are rather basic and only check that each component renders some "basic" elements like for example the product name, the products of a category, etc, without going into all the possible details. The scope of each test could be extended if needed, the main goal here is to ensure that each component properly renders and all elements (components, graphql client, etc, work together).

Note that the it/http project is ignored when we perform a release by setting the skip-it Maven profile during the release.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

cjelger added 8 commits July 22, 2020 17:01
- use new client for tests to use HTTP instead of HTTPS
- add ITs for productlist and productteaser components
- add basic ITs for all components
- do not install WCM Core components with Cloud SDK
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #347 into master will increase coverage by 22.68%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #347       +/-   ##
=============================================
+ Coverage     65.63%   88.31%   +22.68%     
- Complexity      821      852       +31     
=============================================
  Files           192       80      -112     
  Lines          5843     2876     -2967     
  Branches        912      259      -653     
=============================================
- Hits           3835     2540     -1295     
+ Misses         1879      210     -1669     
+ Partials        129      126        -3     
Flag Coverage Δ Complexity Δ
#integration 66.86% <ø> (?) 628.00 <ø> (?)
#karma 93.93% <ø> (?) 0.00 <ø> (?)
#unittests 85.81% <ø> (?) 821.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...eact-components/src/components/Minicart/product.js
...nents/Checkout/paymentProviders/nonceValidation.js
react-components/src/utils/test-utils.js
...es/mutation_add_simple_and_virtual_to_cart.graphql
.../components/Checkout/paymentProviders/braintree.js
...src/queries/mutation_revoke_customer_token.graphql
react-components/src/components/Select/select.js
...eact-components/src/components/Minicart/section.js
react-components/src/utils/hooks.js
react-components/src/components/Checkout/form.js
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f78113...60866a8. Read the comment docs.

@herzog31
Copy link
Member

Just noticed, but might be unrelated to this PR. The integration tests correctly report the integration flag for codecov. The flags for unittests, karma and jest are somehow not correctly applied. Maybe we should update the orb or use the bash uploader directly.

@cjelger
Copy link
Contributor Author

cjelger commented Jul 27, 2020

@herzog31 I fixed the codecov flags by setting the orb to the 1.1.1 latest version.

@cjelger cjelger merged commit 79e7a5b into master Jul 28, 2020
@cjelger cjelger deleted the CIF-1498 branch July 28, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants