Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1156 - Live copy catalog does not show if node name is not language code #315

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Jun 22, 2020

  • updated to Core WCM Components 2.9.0 which included the actual fix

Related Issue

CIF-1156

How Has This Been Tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

…ge code

 * updated to Core WCM Components 2.9.0 which included the actual fix
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #315 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #315   +/-   ##
=========================================
  Coverage     62.16%   62.16%           
  Complexity      809      809           
=========================================
  Files           175      175           
  Lines          5165     5165           
  Branches        875      875           
=========================================
  Hits           3211     3211           
  Misses         1826     1826           
  Partials        128      128           
Flag Coverage Δ Complexity Δ
#jest 43.02% <ø> (ø) 0.00 <ø> (ø)
#unittests 85.77% <ø> (ø) 809.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007cc44...950b2e2. Read the comment docs.

@herzog31 herzog31 added bug Something isn't working verified labels Jun 24, 2020
@herzog31 herzog31 merged commit bd25ff1 into master Jun 24, 2020
@herzog31 herzog31 deleted the CIF-1156 branch June 24, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants