Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default configuration of i18next-browser-languagedetector #311

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

herzog31
Copy link
Member

Description

  • Remove some default configuration of i18next-browser-languagedetector which is considered problematic.

Related Issue

Fixes #302.

How Has This Been Tested?

  • Manual test, also covered by Jest tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the bug Something isn't working label Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #311 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #311   +/-   ##
=========================================
  Coverage     64.62%   64.62%           
  Complexity      809      809           
=========================================
  Files           181      181           
  Lines          5631     5631           
  Branches        875      875           
=========================================
  Hits           3639     3639           
  Misses         1864     1864           
  Partials        128      128           
Flag Coverage Δ Complexity Δ
#jest 42.44% <ø> (ø) 0.00 <ø> (ø)
#karma 94.51% <ø> (ø) 0.00 <ø> (ø)
#unittests 85.77% <ø> (ø) 809.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8dd61e...68479c9. Read the comment docs.

@herzog31 herzog31 merged commit 68ded2c into master Jun 22, 2020
@herzog31 herzog31 deleted the issue/302 branch June 22, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to more inclusive language
2 participants