CIF-1464 - The FeaturedCategoryList component does not use the UrlPro… #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider service - replaced hard-coded String format with urlProvider
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
============================================
+ Coverage 64.74% 64.77% +0.02%
Complexity 802 802
============================================
Files 179 179
Lines 5597 5601 +4
Branches 875 875
============================================
+ Hits 3624 3628 +4
Misses 1848 1848
Partials 125 125
Continue to review full report at Codecov.
|
cjelger
requested review from
herzog31,
mhaack,
dplaton,
LSantha,
laurentiumagureanu and
hbacila
mhaack
approved these changes
Jun 17, 2020
herzog31
reviewed
Jun 17, 2020
| @@ -120,7 +127,8 @@ private void initModel() { | |||
| } | |||
| List<CategoryTree> categories = categoriesRetriever.fetchCategories(); | |||
| for (CategoryTree category : categories) { | |||
| category.setPath(String.format("%s.%s.html", categoryPage.getPath(), category.getId())); | |||
| Map<String, String> params = new ParamsBuilder().id(category.getId().toString()).map(); | |||
There was a problem hiding this comment.
CategoriesRetriever is also fetching the url_path (see https://github.com/adobe/aem-core-cif-components/blob/master/bundles/core/src/main/java/com/adobe/cq/commerce/core/components/internal/models/v1/categorylist/CategoriesRetriever.java#L29-L33). So why not pass it to the url provider as well?
There was a problem hiding this comment.
Good point, I added that
…vider service - also pass url_path to UrlProvider
herzog31
approved these changes
Jun 17, 2020
dplaton
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vider service
How Has This Been Tested?
Extended unit test + manually tested.
Types of changes
Checklist: