Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1364: Show count in productcollection template #301

Merged
merged 4 commits into from
Jun 15, 2020
Merged

Conversation

laurentiumagureanu
Copy link
Collaborator

Description

Shows product count in PLP and search page

Related Issue

CIF-1364

Motivation and Context

Shows product count in PLP and search page

How Has This Been Tested?

Manually

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #301 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #301   +/-   ##
=========================================
  Coverage     64.39%   64.39%           
  Complexity      778      778           
=========================================
  Files           175      175           
  Lines          5471     5471           
  Branches        857      857           
=========================================
  Hits           3523     3523           
  Misses         1835     1835           
  Partials        113      113           
Flag Coverage Δ Complexity Δ
#jest 42.20% <ø> (ø) 0.00 <ø> (ø)
#karma 94.89% <ø> (ø) 0.00 <ø> (ø)
#unittests 86.83% <ø> (ø) 778.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5a8cf...3cd1990. Read the comment docs.

@cjelger cjelger added the enhancement New feature or request label Jun 15, 2020
@herzog31 herzog31 merged commit 4e821ff into master Jun 15, 2020
@herzog31 herzog31 deleted the issues/CIF-1364 branch June 15, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants