Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1426 - [AEMaaCS] The URLProviderConfiguration service is misconfi… #295

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Jun 5, 2020

…gured

  • add support for both variables format ${var} and {{var}}
  • set default new format to {{var}}

I will update the wiki documentation after the PR is merged.

Related Issue

The ${var} format for variables is not compatible with the AEM as a Cloud Service configuration format.

How Has This Been Tested?

Extended unit tests and manually tested with our venia demo.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

…gured

- add support for both variables format ${var} and {{var}}
- set default new format to {{var}}
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #295 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #295      +/-   ##
============================================
+ Coverage     64.23%   64.25%   +0.02%     
- Complexity      768      769       +1     
============================================
  Files           175      175              
  Lines          5449     5453       +4     
  Branches        854      855       +1     
============================================
+ Hits           3500     3504       +4     
  Misses         1835     1835              
  Partials        114      114              
Flag Coverage Δ Complexity Δ
#jest 42.20% <ø> (ø) 0.00 <ø> (ø)
#karma 94.89% <ø> (ø) 0.00 <ø> (ø)
#unittests 86.67% <100.00%> (+0.02%) 769.00 <0.00> (+1.00)
Impacted Files Coverage Δ Complexity Δ
.../components/internal/services/UrlProviderImpl.java 85.41% <100.00%> (+1.32%) 20.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c43037...2227769. Read the comment docs.

@cjelger cjelger added the bug Something isn't working label Jun 5, 2020
@herzog31 herzog31 changed the title CIF-1426 - [Skyline] The URLProviderConfiguration service is misconfi… CIF-1426 - [AEMaaCS] The URLProviderConfiguration service is misconfi… Jun 5, 2020
…gured

- re-add file wrongly deleted by last commit
@LSantha LSantha merged commit b0d1c61 into master Jun 10, 2020
@LSantha LSantha deleted the CIF-1426 branch June 10, 2020 12:00
@LSantha LSantha removed the To Verify label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants