-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-918: remove unused PageContext #280
Conversation
Fix safe loading for window.CIF in CommerceGraphqlApi
@laurentiumagureanu , could you please check if we still need the PageContext mock at https://github.com/adobe/aem-core-cif-components/blob/master/ui.apps/test/components/commerce/navigation/navigationTest.js#L25 ? |
Yeah, I don't know how I missed that one, I searched for all references of |
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
=========================================
Coverage 63.58% 63.59%
Complexity 757 757
=========================================
Files 175 175
Lines 5440 5441 +1
Branches 853 853
=========================================
+ Hits 3459 3460 +1
Misses 1864 1864
Partials 117 117
Continue to review full report at Codecov.
|
Description
PageContext is not used anymore as it's functionality was replaced in React Components
Related Issue
CIF-918
How Has This Been Tested?
Manually
Types of changes
Checklist: