Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1383 - Create the Core CIF Components library pages - productlist… #276

Merged
merged 1 commit into from
May 20, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented May 20, 2020

… component

To be able to display search aggregations/facets, this PR also updates the GraphQL Magento schema with the Luma sample data.

Screenshot 2020-05-19 at 15 23 33

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #276 into master will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #276   +/-   ##
=========================================
  Coverage     63.20%   63.20%           
- Complexity      754      755    +1     
=========================================
  Files           173      173           
  Lines          5354     5357    +3     
  Branches        840      841    +1     
=========================================
+ Hits           3384     3386    +2     
  Misses         1855     1855           
- Partials        115      116    +1     
Flag Coverage Δ Complexity Δ
#jest 40.82% <ø> (ø) 0.00 <ø> (ø)
#karma 94.88% <ø> (ø) 0.00 <ø> (ø)
#unittests 85.17% <83.33%> (-0.03%) 755.00 <1.00> (+1.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
...ommerce/core/examples/servlets/GraphqlServlet.java 90.83% <83.33%> (-0.57%) 31.00 <1.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4571ea5...67a8c84. Read the comment docs.

@cjelger cjelger added documentation Documentation issue To Verify labels May 20, 2020
@cjelger cjelger requested a review from hbacila May 20, 2020 06:58
@hbacila hbacila merged commit f201151 into master May 20, 2020
@hbacila hbacila deleted the CIF-1383 branch May 20, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issue To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants