CIF-1328: Refactor the Create Account process

[laurentiumagureanu]

Description

1. The shopper fills in the required data and clicks the "Create account" button.
2. The account is created and then the shopper is presented with a message Your account was successfully created. You will receive a link at {{email}}. Access that link to confirm your email address. and a Sign in button.
3. The shopper logs in.

Related Issue

CIF-1328

Motivation and Context

In our current implementation, the Create Account process automatically logs in the user after the account is created. This goes against the good practices in the industry because usually Create Account and Sign in are two separate user actions.

How Has This Been Tested?

• unit tests
• manual functional testing

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes and the overall coverage did not decrease.
• All unit tests pass on CircleCi.
• I ran all tests locally and they pass.

[herzog31]

expect(getByText('Sign in')) should be sufficient, since the getBy* query throws an error if an element cannot be found. See https://testing-library.com/docs/dom-testing-library/api-queries#getby.

[laurentiumagureanu]

True but expect is rarely used without a matcher.
It also fails linting.

[herzog31]

Same here. You could write:

await waitForElement(() => getByTestId('sign_in')); // fails if element cannot be found after timeout
expect(result.textContent).toEqual('Sign in page');

[codecov]

Codecov Report

Merging #274 into master will increase coverage by 0.43%.
The diff coverage is 94.68%.

@@             Coverage Diff              @@
##             master     #274      +/-   ##
============================================
+ Coverage     63.15%   63.58%   +0.43%     
  Complexity      757      757              
============================================
  Files           173      175       +2     
  Lines          5368     5440      +72     
  Branches        843      853      +10     
============================================
+ Hits           3390     3459      +69     
- Misses         1861     1864       +3     
  Partials        117      117              

Flag	Coverage Δ	Complexity Δ
#jest	42.13% <94.68%> (+1.39%)	0.00 <0.00> (ø)
#karma	94.88% <ø> (ø)	0.00 <ø> (ø)
#unittests	85.16% <ø> (ø)	757.00 <ø> (ø)

Impacted Files	Coverage Δ	Complexity Δ
react-components/src/context/UserContext.js	90.00% <0.00%> (+0.34%)	0.00 <0.00> (ø)
react-components/src/context/NavigationContext.js	93.18% <93.18%> (ø)	0.00 <0.00> (?)
react-components/src/actions/navigation/actions.js	100.00% <100.00%> (ø)	0.00 <0.00> (?)
...s/src/components/CreateAccount/useCreateAccount.js	100.00% <100.00%> (ø)	0.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2d42a...6531426. Read the comment docs.