Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIF-1394 - Product asset drag'n'drop on a page should configure produ… #273

Merged
merged 1 commit into from
May 18, 2020
Merged

CIF-1394 - Product asset drag'n'drop on a page should configure produ… #273

merged 1 commit into from
May 18, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented May 18, 2020

…ct teaser

  • fix drag and drop

@cjelger cjelger added the bug Something isn't working label May 18, 2020
@codecov
Copy link

codecov bot commented May 18, 2020 •
edited
Loading

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     63.20%   63.20%           
  Complexity      754      754           
=========================================
  Files           173      173           
  Lines          5354     5354           
  Branches        840      840           
=========================================
  Hits           3384     3384           
  Misses         1855     1855           
  Partials        115      115
Flag Coverage Δ Complexity Δ
#jest 40.82% <ø> (ø) 0.00 <ø> (ø)
#karma 94.88% <ø> (ø) 0.00 <ø> (ø)
#unittests 85.20% <ø> (ø) 754.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0824883...55e0be8. Read the comment docs.

@dplaton dplaton merged commit ba74d8e into master May 18, 2020
@dplaton dplaton deleted the CIF-1394 branch May 18, 2020 12:26
cjelger added a commit that referenced this pull request Jun 16, 2020
@cjelger
Revert "CIF-1394 - Product asset drag'n'drop on a page should configu…
0666c9c 
…re product teaser (#273)"

This reverts commit ba74d8e.
@cjelger cjelger mentioned this pull request Jun 16, 2020
Merged
herzog31 added a commit that referenced this pull request Jun 18, 2020
@cjelger @herzog31
Revert "CIF-1394 - Product asset drag'n'drop on a page should configu…
551de8d 
…re product teaser (#273)" (#306)

This reverts commit ba74d8e.

Co-authored-by: Mark J. Becker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplaton dplaton dplaton approved these changes

@mhaack mhaack mhaack approved these changes

@herzog31 herzog31 herzog31 approved these changes

@LSantha LSantha Awaiting requested review from LSantha

@laurentiumagureanu laurentiumagureanu Awaiting requested review from laurentiumagureanu

@hbacila hbacila Awaiting requested review from hbacila

Assignees
No one assigned
Labels
bug Something isn't working To Verify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjelger @dplaton @mhaack @herzog31