Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1375 - Wrong title in design dialog of related products component #264

Merged
merged 4 commits into from
May 8, 2020

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented May 7, 2020

  • fixed dialog title and trackingFeature of design dialog

Description

The title currently is "Product Carousel", it should be "Related Products".
The trackingFeature property of the dialog should also refer to related products.

Related Issue

CIF-1375

How Has This Been Tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #264   +/-   ##
=========================================
  Coverage     62.92%   62.92%           
  Complexity      752      752           
=========================================
  Files           171      171           
  Lines          5352     5352           
  Branches        838      838           
=========================================
  Hits           3368     3368           
  Misses         1868     1868           
  Partials        116      116           
Flag Coverage Δ Complexity Δ
#jest 40.21% <ø> (ø) 0.00 <ø> (ø)
#karma 94.88% <ø> (ø) 0.00 <ø> (ø)
#unittests 85.15% <ø> (ø) 752.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d2721...7ee0e3a. Read the comment docs.

@LSantha LSantha added the bug Something isn't working label May 7, 2020
@laurentiumagureanu laurentiumagureanu merged commit c927862 into master May 8, 2020
@laurentiumagureanu laurentiumagureanu deleted the CIF-1375 branch May 8, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants