-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1329 - Reset the context data between checking out and showing the receipt #255
Conversation
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
============================================
+ Coverage 62.92% 63.20% +0.27%
Complexity 752 752
============================================
Files 171 172 +1
Lines 5352 5360 +8
Branches 838 840 +2
============================================
+ Hits 3368 3388 +20
+ Misses 1868 1856 -12
Partials 116 116
Continue to review full report at Codecov.
|
@@ -144,6 +147,10 @@ const UserContextProvider = props => { | |||
} | |||
}; | |||
|
|||
const resetCustomerCart = async () => { | |||
await resetCustomerCartAction({ fetchCustomerCartQuery, dispatch }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should proxy this call. The components can bring their own query (in case of customizations) so maybe we should get that as an argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the query as a argument to the exposed function.
@dplaton can you have a look again please? |
Description
How Has This Been Tested?
Types of changes
Checklist: