Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1342 - CIF core components bundle depends on commerce core bundle #250

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Apr 7, 2020

  • replaced com.adobe.cq.commerce.common.ValueMapDecorator with org.apache.sling.api.wrappers.ValueMapDecorator

Description

Class RelationTypesDataSourceServlet of related products uses com.adobe.cq.commerce.common.ValueMapDecorator and this makes the components bundle fail on AEMaaCS.

Related Issue

CIF-1322

How Has This Been Tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

 * replaced com.adobe.cq.commerce.common.ValueMapDecorator with org.apache.sling.api.wrappers.ValueMapDecorator
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #250 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #250   +/-   ##
=========================================
  Coverage     60.50%   60.50%           
  Complexity      568      568           
=========================================
  Files           151      151           
  Lines          4631     4631           
  Branches        767      767           
=========================================
  Hits           2802     2802           
  Misses         1742     1742           
  Partials         87       87           
Flag Coverage Δ Complexity Δ
#jest 39.75% <ø> (ø) 0.00 <ø> (ø)
#karma 94.83% <ø> (ø) 0.00 <ø> (ø)
#unittests 85.66% <ø> (ø) 568.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...elatedproducts/RelationTypesDataSourceServlet.java 92.85% <ø> (ø) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d5e04...36f5bed. Read the comment docs.

@LSantha LSantha changed the title CIF-1322 - Cache GraphQL response for Navigation component CIF-1342 - CIF core components bundle depends on commerce core bundle Apr 7, 2020
@LSantha LSantha merged commit 4abbc0f into master Apr 7, 2020
@LSantha LSantha deleted the CIF-1342 branch April 7, 2020 14:25
@LSantha LSantha restored the CIF-1342 branch April 7, 2020 14:30
LSantha added a commit that referenced this pull request Apr 8, 2020
@LSantha LSantha added the bug Something isn't working label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants