-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1256 - Better customizable PLP/PDP URL generation #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added an OSGi service to generate PDP and PLP urls based on string templates
- modified product and productList components and retrievers to parse and fetch data based on the configuration of the UrlProvider service
- replace deprecated SiteNavigation methods with UrlProvider
- add example dispatcher config
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
============================================
+ Coverage 60.50% 60.93% +0.42%
- Complexity 568 582 +14
============================================
Files 151 153 +2
Lines 4631 4710 +79
Branches 767 775 +8
============================================
+ Hits 2802 2870 +68
- Misses 1742 1748 +6
- Partials 87 92 +5
Continue to review full report at Codecov.
|
- removed code moved to UrlProviderImpl
mhaack
reviewed
Apr 2, 2020
- embed commons-text in ui.apps
- revert change to dispatcher config (no longer needed)
mhaack
approved these changes
Apr 3, 2020
herzog31
approved these changes
Apr 3, 2020
10 tasks
# Conflicts: # bundles/core/src/test/java/com/adobe/cq/commerce/core/components/internal/models/v1/product/ProductImplTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: adobe/aem-cif-project-archetype#100
Description
This PR adds an OSGi service to provide configurable PDP and PLP urls. See the related PR in the archetype repo for an example. The documentation will be added to the wiki after the PR is merged.
The PR is large but the main code to review is in
UrlProvider
andUrlProviderImpl
. The rest is the refactoring to replaceSiteNavigation
byUrlProvider
in all the components and tests.How Has This Been Tested?
Extended unit tests and manually tested.
Types of changes
Checklist: