-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1330 - GraphQL endpoint used by client-side code should be configurable #244
Conversation
|
||
String getStoreView(); | ||
|
||
String getGraphqlEndpoint(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is public API, some Javadoc would be nice.
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=========================================
Coverage 61.29% 61.29%
Complexity 566 566
=========================================
Files 150 150
Lines 4557 4558 +1
Branches 758 757 -1
=========================================
+ Hits 2793 2794 +1
Misses 1679 1679
Partials 85 85
Continue to review full report at Codecov.
|
Description
StoreViewExporter
toStoreConfigExporter
and added Magento GraphQL endpoint as exported property.Types of changes
Checklist: