Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1330 - GraphQL endpoint used by client-side code should be configurable #244

Merged
merged 5 commits into from
Mar 31, 2020

Conversation

herzog31
Copy link
Member

Description

  • Added option to cloud configuration to set client-side Magento GraphQL endpoint
  • Renamed StoreViewExporter to StoreConfigExporter and added Magento GraphQL endpoint as exported property.
  • Updated React and JavaScript code to get GraphQL endpoint from the page model.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.


String getStoreView();

String getGraphqlEndpoint();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is public API, some Javadoc would be nice.

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #244 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #244   +/-   ##
=========================================
  Coverage     61.29%   61.29%           
  Complexity      566      566           
=========================================
  Files           150      150           
  Lines          4557     4558    +1     
  Branches        758      757    -1     
=========================================
+ Hits           2793     2794    +1     
  Misses         1679     1679           
  Partials         85       85           
Flag Coverage Δ Complexity Δ
#jest 40.68% <ø> (ø) 0.00 <ø> (ø)
#karma 94.81% <100.00%> (-0.02%) 0.00 <0.00> (ø)
#unittests 85.74% <100.00%> (+0.01%) 566.00 <3.00> (ø)
Impacted Files Coverage Δ Complexity Δ
...1/storeconfigexporter/StoreConfigExporterImpl.java 100.00% <100.00%> (ø) 4.00 <3.00> (?)
...ore/cif/clientlibs/common/js/CommerceGraphqlApi.js 85.48% <100.00%> (-0.24%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c890ec...fc262ce. Read the comment docs.

@dplaton dplaton merged commit 7ddd3da into master Mar 31, 2020
@dplaton dplaton deleted the issue/CIF-1330 branch March 31, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants