-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1300 - Implement mock GraphQL HTTP endpoint for the components library pages #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…brary pages - Refactored unit tests by adapting and using the CIF components sling models for testing
…brary pages - extended unit tests for more components
…brary pages - added javadoc - replaced image urls with dummy urls
…brary pages - fix CI build
…brary pages - fix codecov config
mhaack
approved these changes
Mar 16, 2020
…brary pages - remove unneeded JSON
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
============================================
+ Coverage 62.32% 63.00% +0.67%
- Complexity 728 758 +30
============================================
Files 171 172 +1
Lines 5240 5368 +128
Branches 820 838 +18
============================================
+ Hits 3266 3382 +116
- Misses 1862 1869 +7
- Partials 112 117 +5
Continue to review full report at Codecov.
|
herzog31
approved these changes
Mar 23, 2020
herzog31
added
do not merge
To Verify
feature
New feature or request
verified
and removed
To Verify
labels
Mar 31, 2020
…brary pages - merged with master and adapted to new faceted search service
…brary pages - skip components library artifacts when releasing
…brary pages - fix wrong version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to have a self-contained content package for the components library pages, we develop a mock GraphQL HTTP endpoint that would contain sample JSON responses for all the CIF components of the library pages.
This PR contains an AEM Servlet that implements that GraphQL server. It uses the
graphql-java
to implement a real GraphQL server using the Magento2.3.4
GraphQL schema. The JSON responses are mocked, and should be refined/adapted when we will start developing the library pages.How Has This Been Tested?
The Servlet has been tested with all the server-side CIF Components that will be potentially used in the library pages. Each test uses the corresponding Sling Model and data retriever, so we exactly test all the GraphQL queries issued by the components.
Screenshots (if appropriate):
Types of changes
Checklist: