Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ufoLib to 2.3.0 #486

Closed
wants to merge 1 commit into from
Closed

Update ufoLib to 2.3.0 #486

wants to merge 1 commit into from

Conversation

miguelsousa
Copy link
Member

No description provided.

@miguelsousa
Copy link
Member Author

The tests won't pass until mutatorMath gets an update. See unified-font-object/ufoLib#160 (comment)

@miguelsousa
Copy link
Member Author

@anthrotype are the data/string differences supposed to happen if ufoLib version 2.3.0 is installed without the lxml option? I was under the impression that you kept the previous behavior by default.

@anthrotype
Copy link
Member

I just said that ufoLib now behaves the same way both with or without lxml and in python 2 or python 3. Any of these bytes-that-should-be-unicode should get fixed.

@anthrotype
Copy link
Member

Of course they only affect python 2.7, where this confusion can happen

@miguelsousa
Copy link
Member Author

thanks. Can you confirm my assessment that mutatorMath has bytes-that-should-be-unicode things to fix?

@anthrotype
Copy link
Member

Can you confirm my assessment that mutatorMath has bytes-that-should-be-unicode things to fix?

I had underestimated this issue.. Requiring all clients of ufoLib to consistently use unicode instead of bytes (==str in python2) anywhere a plist string can occur is too demanding for old python2 code...

I need to revise my approach in the new ufoLib.plistlib. Instead of forcing python2 to behave like python3 (where the text / binary data is clear), I need to implement the use_builtin_types option in plistlib.load/dump functions, and add support for the deprecated plistlib.Data wrapper class for bytes data.

Python 2 is my nemesis.

@miguelsousa
Copy link
Member Author

Thanks for looking into this Cosimo. There will be a time when we don't have to think about Python 2 anymore.

@cjchapman
Copy link
Contributor

@miguelsousa @anthrotype I think we should throw a party when that time comes.

@benkiel
Copy link
Contributor

benkiel commented Jul 19, 2018

Python 2 is my nemesis.

And we can get t-shirts with this!

@miguelsousa
Copy link
Member Author

Or: Python 2 is was my nemesis

@benkiel
Copy link
Contributor

benkiel commented Jul 19, 2018

Or: Python 2 is was my nemesis

To state the obvious, the is is crossed out by a snake.

@khaledhosny
Copy link
Collaborator

khaledhosny commented Jul 19, 2018 via email

miguelsousa added a commit that referenced this pull request Jul 20, 2018
Cap the version of ufoLib until Cosimo revises his approach in the new `ufoLib.plistlib`. See #486.
@miguelsousa miguelsousa deleted the ufolib-update branch July 20, 2018 15:30
miguelsousa added a commit that referenced this pull request Jul 20, 2018
Cap the version of ufoLib until Cosimo revises his approach in the new `ufoLib.plistlib`. See #486.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants