Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redmine): Display billable hours #599

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

Melkor333
Copy link
Contributor

As we often have to subtract the non-billable hours from project estimation calculations & customer communication, it would be super neat to see the current billable hours in the redmine report.

I wondered if it's hard to implement and it looks rather trivial. Though I'm a bit overwhelmed with the testing and would be glad to have some pointers.

@Melkor333 Melkor333 force-pushed the redmine-report-billable-hours branch 2 times, most recently from 9d11dbb to fafaa6f Compare February 10, 2025 15:06
@Melkor333 Melkor333 force-pushed the redmine-report-billable-hours branch 7 times, most recently from cc59a42 to 242451d Compare February 11, 2025 12:19
@Melkor333 Melkor333 force-pushed the redmine-report-billable-hours branch from 242451d to 19ea2d2 Compare February 11, 2025 14:10
@Melkor333 Melkor333 marked this pull request as ready for review February 11, 2025 14:11
@Melkor333 Melkor333 requested a review from a team as a code owner February 11, 2025 14:11
@Melkor333
Copy link
Contributor Author

FWIW I took a second look at the testing today and added the billable_hours to both existing report tests. I also made the second test generate some reports with and some without billing to make sure it does a proper calculation.

Copy link
Collaborator

@c0rydoras c0rydoras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Melkor333 Melkor333 merged commit 0a3db39 into main Feb 11, 2025
10 checks passed
@Melkor333 Melkor333 deleted the redmine-report-billable-hours branch February 11, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants