chore(frontend): eslint v9 (#612)

* chore(frontend): update linting

update to eslint v9
update most eslint-* deps
update stylelint
etc.

* fix(frontend): run eslint . --fix

* chore(frontend): manually fix remaining eslint errors

frontend/.stylelintrc.js

@@ -8,7 +8,7 @@ module.exports = {
     "at-rule-empty-line-before": ["never", { ignoreAtRules: ["import"] }], // we use empty lines to group/order imports (su)
     "selector-class-pattern": null, // we can ignore this because most css is styling 3rd party components where we don't control the class names
     "import-notation": null, // doesn't really work with postcss-import
-    "at-rule-no-unknown": [
+    "at-rule-no-deprecated": [
       true,
       {
         ignoreAtRules: ["apply"], // ignore tailwind decorators

frontend/app/abilities/report.js

@@ -12,9 +12,7 @@ export default class ReportAbility extends Ability {
     const isEditable =
       this.user?.isSuperuser ||
       (!this.model?.verifiedBy?.get("id") &&
-        // eslint-disable-next-line ember/no-get
         (this.model?.user?.get("id") === this.user?.get("id") ||
-          // eslint-disable-next-line ember/no-get
           (this.model?.user?.get("supervisors") ?? [])
             .map((s) => s.id)
             .includes(this.user?.get("id"))));

frontend/app/analysis/edit/controller.js

@@ -6,6 +6,7 @@ import { service } from "@ember/service";
 import { dasherize } from "@ember/string";
 import { tracked } from "@glimmer/tracking";
 import { task } from "ember-concurrency";
+
 import {
   underscoreQueryParams,
   serializeQueryParams,
@@ -205,7 +206,7 @@ export default class AnalysisEditController extends Controller {
       });
 
       this.notify.success("Reports were saved");
-    } catch (e) {
+    } catch {
       this.notify.error("Error while saving the reports");
     }
 

frontend/app/analysis/edit/route.js

@@ -1,4 +1,5 @@
 import Route from "@ember/routing/route";
+
 import { resetQueryParams } from "timed/utils/query-params";
 
 export default class AnalysisEditRoute extends Route {

frontend/app/analysis/index/controller.js

@@ -13,6 +13,9 @@ import {
 } from "ember-concurrency";
 import fetch from "fetch";
 import moment from "moment";
+
+import config from "../../config/environment";
+
 import QPController from "timed/controllers/qpcontroller";
 import parseDjangoDuration from "timed/utils/parse-django-duration";
 import parseFileName from "timed/utils/parse-filename";
@@ -24,8 +27,6 @@ import {
 import { serializeMoment } from "timed/utils/serialize-moment";
 import { cleanParams, toQueryString } from "timed/utils/url";
 
-import config from "../../config/environment";
-
 export default class AnalysisController extends QPController {
   queryParams = [
     "customer",
@@ -341,8 +342,7 @@ export default class AnalysisController extends QPController {
       download(file, filename, file.type);
 
       this.notify.success("File was downloaded");
-    } catch (e) {
-      /* istanbul ignore next */
+    } catch {
       this.notify.error(
         "Error while downloading, try again or try reducing results",
       );

frontend/app/app.js

@@ -6,6 +6,7 @@ import { registerDateLibrary } from "ember-power-calendar";
 import DateUtils from "ember-power-calendar-moment";
 import Resolver from "ember-resolver";
 import fastRedact from "fast-redact";
+
 import config from "timed/config/environment";
 
 import "simplebar";

frontend/app/components/attendance-slider.js

@@ -9,6 +9,7 @@ import Component from "@glimmer/component";
 import { tracked } from "@glimmer/tracking";
 import { dropTask } from "ember-concurrency";
 import moment from "moment";
+
 import formatDuration from "timed/utils/format-duration";
 import { pad2joincolon } from "timed/utils/pad";
 

frontend/app/components/datepicker-button.js

@@ -5,9 +5,10 @@
  */
 
 import { action } from "@ember/object";
-import Datepicker from "timed/components/datepicker";
 import { localCopy } from "tracked-toolbox";
 
+import Datepicker from "timed/components/datepicker";
+
 /**
  * The datepicker buttn component
  *

frontend/app/components/duration-since.js

@@ -76,7 +76,6 @@ export default class DurationSinceComponent extends Component {
    * @public
    */
   timer = task(async () => {
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       this._compute();
 

frontend/app/components/durationpicker-day.js

@@ -1,5 +1,6 @@
 import { action } from "@ember/object";
 import moment from "moment";
+
 import DurationpickerComponent from "timed/components/durationpicker";
 import parseDayTime from "timed/utils/parse-daytime";
 

frontend/app/components/durationpicker.js

@@ -2,9 +2,10 @@ import { action } from "@ember/object";
 import { guidFor } from "@ember/object/internals";
 import { tracked } from "@glimmer/tracking";
 import moment from "moment";
+import { localCopy } from "tracked-toolbox";
+
 import TimepickerComponent from "timed/components/timepicker";
 import formatDuration from "timed/utils/format-duration";
-import { localCopy } from "tracked-toolbox";
 
 const { MIN_SAFE_INTEGER, MAX_SAFE_INTEGER } = Number;
 const { abs } = Math;

frontend/app/components/report-row.js

@@ -2,6 +2,7 @@ import { action } from "@ember/object";
 import { service } from "@ember/service";
 import Component from "@glimmer/component";
 import { dropTask } from "ember-concurrency";
+
 import ReportValidations from "timed/validations/report";
 
 export default class ReportRowComponent extends Component {

frontend/app/components/statistic-list.js

@@ -2,6 +2,7 @@ import { get } from "@ember/object";
 import { capitalize } from "@ember/string";
 import Component from "@glimmer/component";
 import moment from "moment";
+
 import parseDjangoDuration from "timed/utils/parse-django-duration";
 
 const PLAIN_LAYOUT = "PLAIN";

frontend/app/components/task-selection.js

@@ -5,11 +5,12 @@ import Component from "@glimmer/component";
 import { restartableTask, timeout, dropTask } from "ember-concurrency";
 import { trackedTask } from "reactiveweb/ember-concurrency";
 import { resolve } from "rsvp";
+import { localCopy } from "tracked-toolbox";
+
 import customerOptionTemplate from "timed/components/optimized-power-select/custom-options/customer-option";
 import projectOptionTemplate from "timed/components/optimized-power-select/custom-options/project-option";
 import taskOptionTemplate from "timed/components/optimized-power-select/custom-options/task-option";
 import customSelectedTemplate from "timed/components/optimized-power-select/custom-select/task-selection";
-import { localCopy } from "tracked-toolbox";
 /**
  * Component for selecting a task, which consists of selecting a customer and
  * project first.

frontend/app/components/timed-clock.js

@@ -28,7 +28,6 @@ export default class TimedClock extends Component {
   }
 
   timer = task(async () => {
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       this._update();
 

frontend/app/components/user-selection.js

@@ -3,6 +3,7 @@ import Component from "@glimmer/component";
 import { tracked } from "@glimmer/tracking";
 import { restartableTask } from "ember-concurrency";
 import { trackedTask } from "reactiveweb/ember-concurrency";
+
 import customOptionTemplate from "timed/components/optimized-power-select/custom-options/user-option";
 import customSelectedTemplate from "timed/components/optimized-power-select/custom-select/user-selection";
 

frontend/app/components/worktime-balance-chart.js

@@ -1,5 +1,6 @@
 import Component from "@glimmer/component";
 import moment from "moment";
+
 import humanizeDuration from "timed/utils/humanize-duration";
 
 // TODO: take this from tailwind.config.js

frontend/app/helpers/format-duration.js

@@ -4,6 +4,7 @@
  * @public
  */
 import { helper } from "@ember/component/helper";
+
 import formatDuration from "timed/utils/format-duration";
 
 /**

frontend/app/helpers/humanize-duration.js

@@ -4,6 +4,7 @@
  * @public
  */
 import { helper } from "@ember/component/helper";
+
 import humanizeDuration from "timed/utils/humanize-duration";
 
 /**

frontend/app/helpers/parse-django-duration.js

@@ -4,6 +4,7 @@
  * @public
  */
 import { helper } from "@ember/component/helper";
+
 import parseDjangoDuration from "timed/utils/parse-django-duration";
 
 /**

frontend/app/index/activities/controller.js

@@ -223,8 +223,7 @@ export default class ActivitiesIndexController extends Controller {
         }, resolve());
 
       this.router.transitionTo("index.reports");
-    } catch (e) {
-      /* istanbul ignore next */
+    } catch {
       this.notify.error("Error while generating reports");
     } finally {
       this.tracking.generatingReports = false;

frontend/app/index/activities/edit/route.js

@@ -7,6 +7,7 @@ import Route from "@ember/routing/route";
 import { service } from "@ember/service";
 import Changeset from "ember-changeset";
 import lookupValidator from "ember-changeset-validations";
+
 import ActivityValidator from "timed/validations/activity";
 
 /**

frontend/app/index/attendances/controller.js

@@ -6,6 +6,7 @@
 import Controller from "@ember/controller";
 import { action } from "@ember/object";
 import { service } from "@ember/service";
+
 import AttendanceValidator from "timed/validations/attendance";
 
 /**
@@ -73,8 +74,7 @@ export default class AttendanceController extends Controller {
       await attendance.save();
 
       this.notify.success("Attendance was saved");
-    } catch (e) {
-      /* istanbul ignore next */
+    } catch {
       this.notify.error("Error while saving the attendance");
     }
   }
@@ -92,8 +92,7 @@ export default class AttendanceController extends Controller {
       await this.store.peekRecord("attendance", attendance.id).destroyRecord();
 
       this.notify.success("Attendance was deleted");
-    } catch (e) {
-      /* istanbul ignore next */
+    } catch {
       this.notify.error("Error while deleting the attendance");
     }
   }
@@ -121,8 +120,7 @@ export default class AttendanceController extends Controller {
       await attendance.save();
 
       this.notify.success("Attendance was added");
-    } catch (e) {
-      /* istanbul ignore next */
+    } catch {
       this.notify.error("Error while adding the attendance");
     }
   }

frontend/app/index/controller.js

@@ -8,11 +8,12 @@ import { tracked } from "@glimmer/tracking";
 import { dropTask, timeout } from "ember-concurrency";
 import moment from "moment";
 import { trackedFunction } from "reactiveweb/function";
-import AbsenceValidations from "timed/validations/absence";
-import MultipleAbsenceValidations from "timed/validations/multiple-absence";
 import { tracked as trackedWrapper } from "tracked-built-ins";
 import { cached } from "tracked-toolbox";
 
+import AbsenceValidations from "timed/validations/absence";
+import MultipleAbsenceValidations from "timed/validations/multiple-absence";
+
 /**
  * The index controller
  *
@@ -138,7 +139,6 @@ export default class IndexController extends Controller {
    * @private
    */
   _activitySumTask = dropTask(async () => {
-    // eslint-disable-next-line no-constant-condition
     while (true) {
       this._activitySum();
 
@@ -449,7 +449,7 @@ export default class IndexController extends Controller {
 
     const publicHolidays = await this.store.query("public-holiday", {
       ...params,
-      // eslint-disable-next-line ember/no-get
+
       location: this.currentUser.user.activeEmployment.location.get("id"),
     });
 
@@ -519,8 +519,7 @@ export default class IndexController extends Controller {
       await changeset.save();
 
       this.showEditModal = false;
-    } catch (e) {
-      /* istanbul ignore next */
+    } catch {
       this.notify.error("Error while saving the absence");
     } finally {
       this.send("finished");
@@ -542,8 +541,7 @@ export default class IndexController extends Controller {
       await absence.destroyRecord();
 
       this.showEditModal = false;
-    } catch (e) {
-      /* istanbul ignore next */
+    } catch {
       this.notify.error("Error while deleting the absence");
     } finally {
       this.send("finished");
@@ -579,7 +577,7 @@ export default class IndexController extends Controller {
       changeset.rollback();
 
       this.showAddModal = false;
-    } catch (e) {
+    } catch {
       this.notify.error("Error while adding the absence");
     } finally {
       this.send("finished");

frontend/app/index/reports/controller.js

@@ -10,8 +10,9 @@ import { service } from "@ember/service";
 import { tracked } from "@glimmer/tracking";
 import moment from "moment";
 import { all } from "rsvp";
-import ReportValidations from "timed/validations/report";
 import { cached } from "tracked-toolbox";
+
+import ReportValidations from "timed/validations/report";
 /**
  * The index reports controller
  *
@@ -121,7 +122,7 @@ export default class IndexReportController extends Controller {
       if (this.absence) {
         await this.absence.reload();
       }
-    } catch (e) {
+    } catch {
       this.notify.error("Error while saving the report");
     } finally {
       this.send("finished");
@@ -147,7 +148,7 @@ export default class IndexReportController extends Controller {
           await this.absence.reload();
         }
       }
-    } catch (e) {
+    } catch {
       this.notify.error("Error while deleting the report");
     } finally {
       this.send("finished");
@@ -180,7 +181,7 @@ export default class IndexReportController extends Controller {
       this.router.transitionTo({
         queryParams: { day: date.format("YYYY-MM-DD") },
       });
-    } catch (e) {
+    } catch {
       this.notify.error("Error while rescheduling the timesheet");
     }
   }