refactor: deprecations (#893)

* fix: add the missing package to run the tests

* fix: errors that hided by (routing.transition-methods)

* fix: confirming zero issue in some deprecation workflow

* fix: checking the others deprecation, and testing

* fix: this-property-fallback in deprecated workflow

* fix: this-property-fallback in deprecated workflow

app/index/activities/edit/route.js

@@ -4,6 +4,7 @@
  * @public
  */
 import Route from "@ember/routing/route";
+import { inject as service } from "@ember/service";
 import Changeset from "ember-changeset";
 import lookupValidator from "ember-changeset-validations";
 import RouteAutostartTourMixin from "timed/mixins/route-autostart-tour";
@@ -19,6 +20,7 @@ import ActivityValidator from "timed/validations/activity";
 export default class IndexActivityEditController extends Route.extend(
   RouteAutostartTourMixin
 ) {
+  @service router;
   /**
    * Model hook, fetch the activity to edit
    *
@@ -34,7 +36,7 @@ export default class IndexActivityEditController extends Route.extend(
 
   afterModel(model) {
     if (model.get("transferred")) {
-      this.transitionTo("index");
+      this.router.transitionTo("index");
     }
   }
 

app/users/edit/credits/absence-credits/edit/controller.js

@@ -11,6 +11,7 @@ export default Controller.extend({
   userCreditsController: controller("users.edit.credits.index"),
 
   notify: service("notify"),
+  router: service("router"),
 
   absenceTypes: task(function* () {
     return yield this.store.query("absence-type", {
@@ -49,9 +50,13 @@ export default Controller.extend({
       const year =
         allYears.find((y) => y === String(changeset.get("date").year())) || "";
 
-      yield this.transitionToRoute("users.edit.credits", this.get("user.id"), {
-        queryParams: { year },
-      });
+      yield this.router.transitionTo(
+        "users.edit.credits",
+        this.get("user.id"),
+        {
+          queryParams: { year },
+        }
+      );
     } catch (e) {
       /* istanbul ignore next */
       this.notify.error("Error while saving the absence credit");
@@ -66,7 +71,7 @@ export default Controller.extend({
 
       this.get("userController.data").perform(this.get("user.id"));
 
-      this.transitionToRoute("users.edit.credits");
+      this.router.transitionTo("users.edit.credits");
     } catch (e) {
       /* istanbul ignore next */
       this.notify.error("Error while deleting the absence credit");

app/users/edit/credits/index/controller.js

@@ -20,6 +20,7 @@ export default Controller.extend(UsersEditCreditsQueryParams.Mixin, {
   fetch: service("fetch"),
 
   can: service("can"),
+  router: service("router"),
 
   userController: controller("users.edit"),
 
@@ -109,7 +110,7 @@ export default Controller.extend(UsersEditCreditsQueryParams.Mixin, {
 
   editAbsenceCredit: task(function* (id) {
     if (this.can.can("edit absence-credit")) {
-      yield this.transitionToRoute(
+      yield this.router.transitionTo(
         "users.edit.credits.absence-credits.edit",
         id
       );
@@ -118,7 +119,7 @@ export default Controller.extend(UsersEditCreditsQueryParams.Mixin, {
 
   editOvertimeCredit: task(function* (id) {
     if (this.can.can("edit overtime-credit")) {
-      yield this.transitionToRoute(
+      yield this.router.transitionTo(
         "users.edit.credits.overtime-credits.edit",
         id
       );

app/users/edit/credits/overtime-credits/edit/controller.js

@@ -11,6 +11,7 @@ export default Controller.extend({
   userCreditsController: controller("users.edit.credits.index"),
 
   notify: service("notify"),
+  router: service("router"),
 
   credit: task(function* () {
     const id = this.model;
@@ -41,9 +42,13 @@ export default Controller.extend({
       const year =
         allYears.find((y) => y === String(changeset.get("date").year())) || "";
 
-      yield this.transitionToRoute("users.edit.credits", this.get("user.id"), {
-        queryParams: { year },
-      });
+      yield this.router.transitionTo(
+        "users.edit.credits",
+        this.get("user.id"),
+        {
+          queryParams: { year },
+        }
+      );
     } catch (e) {
       /* istanbul ignore next */
       this.notify.error("Error while saving the overtime credit");
@@ -58,7 +63,7 @@ export default Controller.extend({
 
       this.get("userController.data").perform(this.get("user.id"));
 
-      this.transitionToRoute("users.edit.credits");
+      this.router.transitionTo("users.edit.credits");
     } catch (e) {
       /* istanbul ignore next */
       this.notify.error("Error while deleting the overtime credit");

config/deprecation-workflow.js

@@ -2,23 +2,16 @@
 window.deprecationWorkflow = window.deprecationWorkflow || {};
 window.deprecationWorkflow.config = {
   workflow: [
-    { handler: "silence", matchId: "ember-global" },
-    { handler: "silence", matchId: "ember.component.reopen" },
-    { handler: "silence", matchId: "ember-metal.get-with-default" },
+    { handler: "silence", matchId: "ember.component.reopen" }, // not finish yet
     { handler: "silence", matchId: "implicit-injections" },
     {
-      handler: "silence",
-      matchId: "ember-views.curly-components.jquery-element",
-    },
-    {
+      // the issue exists in ember scrollable package
       handler: "silence",
       matchId: "deprecated-run-loop-and-computed-dot-access",
     },
+    // This error is caused by ember-parachute and will persist
+    // until we have refactored all controllers and routes to not use ember-parachute
     { handler: "silence", matchId: "ember-utils.try-invoke" },
     { handler: "silence", matchId: "this-property-fallback" },
-    { handler: "silence", matchId: "autotracking.mutation-after-consumption" },
-    { handler: "silence", matchId: "manager-capabilities.modifiers-3-13" },
-    { handler: "silence", matchId: "setting-on-hash" },
-    { handler: "silence", matchId: "routing.transition-methods" },
   ],
 };

package.json

@@ -61,6 +61,7 @@
     "@semantic-release/git": "^10.0.1",
     "babel-eslint": "10.1.0",
     "broccoli-asset-rev": "3.0.0",
+    "broccoli-funnel": "^3.0.8",
     "downloadjs": "1.4.7",
     "ember-auto-import": "2.6.0",
     "ember-basic-dropdown": "7.0.0",

tests/acceptance/users-edit-credits-absence-credit-test.js

@@ -26,7 +26,10 @@ module("Acceptance | users edit credits absence credit", function (hooks) {
     await fillIn("input[name=comment]", "Comment");
     await click("[data-test-absence-credit-save]");
 
-    assert.strictEqual(currentURL(), `/users/${this.user.id}/credits`);
+    assert.strictEqual(
+      currentURL(),
+      `/users/${this.user.id}/credits?year=${moment().format("YYYY")}`
+    );
 
     assert.dom("[data-test-absence-credits] tbody > tr").exists({ count: 1 });
   });
@@ -49,7 +52,10 @@ module("Acceptance | users edit credits absence credit", function (hooks) {
 
     await click(".btn-primary");
 
-    assert.strictEqual(currentURL(), `/users/${this.user.id}/credits`);
+    assert.strictEqual(
+      currentURL(),
+      `/users/${this.user.id}/credits?year=${moment().format("YYYY")}`
+    );
 
     assert.dom("[data-test-absence-credits] tbody > tr").exists({ count: 1 });
 
@@ -79,7 +85,10 @@ module("Acceptance | users edit credits absence credit", function (hooks) {
 
     await click(".btn-danger");
 
-    assert.strictEqual(currentURL(), `/users/${this.user.id}/credits`);
+    assert.strictEqual(
+      currentURL(),
+      `/users/${this.user.id}/credits?year=${moment().format("YYYY")}`
+    );
 
     assert.dom("[data-test-absence-credits] tr").doesNotExist();
   });

tests/acceptance/users-edit-credits-overtime-credit-test.js

@@ -25,7 +25,10 @@ module("Acceptance | users edit credits overtime credit", function (hooks) {
 
     await click("[data-test-overtime-credit-save]");
 
-    assert.strictEqual(currentURL(), `/users/${this.user.id}/credits`);
+    assert.strictEqual(
+      currentURL(),
+      `/users/${this.user.id}/credits?year=${moment().format("YYYY")}`
+    );
 
     assert.dom("[data-test-overtime-credits] tbody > tr").exists({ count: 1 });
   });
@@ -48,7 +51,10 @@ module("Acceptance | users edit credits overtime credit", function (hooks) {
 
     await click("[data-test-overtime-credit-save]");
 
-    assert.strictEqual(currentURL(), `/users/${this.user.id}/credits`);
+    assert.strictEqual(
+      currentURL(),
+      `/users/${this.user.id}/credits?year=${moment().format("YYYY")}`
+    );
 
     assert.dom("[data-test-overtime-credits] tbody > tr").exists({ count: 1 });
 
@@ -78,7 +84,10 @@ module("Acceptance | users edit credits overtime credit", function (hooks) {
 
     await click("[data-test-overtime-credit-delete]");
 
-    assert.strictEqual(currentURL(), `/users/${this.user.id}/credits`);
+    assert.strictEqual(
+      currentURL(),
+      `/users/${this.user.id}/credits?year=${moment().format("YYYY")}`
+    );
 
     assert.dom("[data-test-overtime-credits] tr").doesNotExist();
   });

tests/integration/components/async-list/component-test.js

@@ -10,13 +10,13 @@ module("Integration | Component | async list", function (hooks) {
     this.set("data", { last: { value: ["a", "b"] } });
 
     await render(hbs`
-      {{#async-list data as |section data|}}
+      <AsyncList @data={{this.data}} as |section data|>
         {{#if (eq section 'body')}}
           {{#each data as |d|}}
             <div class="item">{{d}}</div>
           {{/each}}
         {{/if}}
-      {{/async-list}}
+      </AsyncList>
     `);
 
     assert.dom("div.item").exists({ count: 2 });
@@ -26,11 +26,11 @@ module("Integration | Component | async list", function (hooks) {
     this.set("data", { last: { value: [] } });
 
     await render(hbs`
-      {{#async-list data as |section data|}}
+      <AsyncList @data={{this.data}} as |section data|>
         {{#if (eq section 'empty')}}
           <div class="check-me"></div>
         {{/if}}
-      {{/async-list}}
+      </AsyncList>
     `);
 
     assert.dom(".check-me").exists();
@@ -40,7 +40,7 @@ module("Integration | Component | async list", function (hooks) {
     this.set("data", { isRunning: true });
 
     await render(hbs`
-      {{#async-list data}}{{/async-list}}
+      <AsyncList @data={{this.data}} />
     `);
 
     assert.dom(".loading-icon").exists();
@@ -50,7 +50,7 @@ module("Integration | Component | async list", function (hooks) {
     this.set("data", { last: { isError: true } });
 
     await render(hbs`
-      {{#async-list data as |section data|}}{{/async-list}}
+    <AsyncList @data={{this.data}} as |section data|></AsyncList>
     `);
 
     assert.dom(".fa-bolt").exists();

tests/integration/components/balance-donut/component-test.js

@@ -13,7 +13,7 @@ module("Integration | Component | balance donut", function (hooks) {
       usedDays: 5,
     });
 
-    await render(hbs`{{balance-donut balance}}`);
+    await render(hbs`<BalanceDonut @balance={{this.balance}} />`);
 
     assert.dom(".donut-content").includesText("5 of 10");
     assert.dom(".donut-content").includesText("50%");
@@ -30,7 +30,7 @@ module("Integration | Component | balance donut", function (hooks) {
       usedDays: 3,
     });
 
-    await render(hbs`{{balance-donut balance}}`);
+    await render(hbs`<BalanceDonut @balance={{this.balance}} />`);
 
     assert.dom(".donut-content").includesText("3");
     assert.dom(".donut-content").doesNotIncludeText("0");
@@ -47,7 +47,7 @@ module("Integration | Component | balance donut", function (hooks) {
       usedDays: 20,
     });
 
-    await render(hbs`{{balance-donut balance}}`);
+    await render(hbs`<BalanceDonut @balance={{this.balance}} />`);
 
     assert.dom(".donut-content").includesText("20 of 10");
     assert.dom(".donut-content").includesText("200%");
@@ -63,7 +63,7 @@ module("Integration | Component | balance donut", function (hooks) {
       usedDuration: moment.duration({ h: 10 }),
     });
 
-    await render(hbs`{{balance-donut balance}}`);
+    await render(hbs`<BalanceDonut @balance={{this.balance}} />`);
 
     assert.dom(".donut-content").includesText("10:00");
 

tests/integration/components/date-buttons/component-test.js

@@ -13,7 +13,11 @@ module("Integration | Component | date buttons", function (hooks) {
     this.set("toDate", null);
 
     await render(
-      hbs`{{date-buttons onUpdateFromDate=(action (mut fromDate)) onUpdateToDate=(action (mut toDate))}}`
+      hbs`<DateButtons
+        @onUpdateFromDate={{(action (mut this.fromDate))}}
+        @onUpdateToDate={{(action (mut this.toDate))}}
+      />
+      `
     );
 
     await click('[data-test-preset-date="0"]');

tests/integration/components/duration-since/component-test.js

@@ -16,7 +16,7 @@ module("Integration | Component | duration since", function (hooks) {
       })
     );
 
-    await render(hbs`{{duration-since start}}`);
+    await render(hbs`<DurationSince @from={{this.start}} />`);
 
     assert.ok(this.element);
     assert.dom(this.element).hasText("00:05:05");
@@ -40,7 +40,9 @@ module("Integration | Component | duration since", function (hooks) {
       })
     );
 
-    await render(hbs`{{duration-since start elapsed=elapsed}}`);
+    await render(
+      hbs`<DurationSince @from={{this.start}} @elapsed={{this.elapsed}} />`
+    );
 
     assert.ok(this.element);
     assert.dom(this.element).hasText("01:06:06");

tests/integration/components/pagination-limit/component-test.js

@@ -14,7 +14,9 @@ module("Integration | Component | pagination limit", function (hooks) {
   test("can change limit", async function (assert) {
     this.set("limit", 10);
 
-    await render(hbs`{{pagination-limit pages=5 page_size=limit}}`);
+    await render(
+      hbs`<PaginationLimit @pages={{5}} @page_size={{this.limit}} />`
+    );
 
     assert.dom("span").exists({ count: 4 });
     assert.dom("a").exists({ count: 3 });