Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(timed): update timed-frontend image tag to v3.0.0-rc3 #933

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

derrabauke
Copy link
Contributor

@derrabauke derrabauke commented Jan 24, 2023

Description

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@derrabauke derrabauke self-assigned this Jan 24, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 24, 2023
@derrabauke derrabauke force-pushed the chore-timed-frontend-upgrade branch 2 times, most recently from f6b991e to 61a3f80 Compare January 24, 2023 10:26
@derrabauke
Copy link
Contributor Author

@trowik you know what's wrong with that?

2023-01-24 10:29:44.204 GMT [176] ERROR: column "estimated_time" of relation "projects_project" already exists)?

@hairmare
Copy link
Contributor

2023-01-24 10:29:44.204 GMT [176] ERROR: column "estimated_time" of relation "projects_project" already exists)?

might be related to this:

i triggered a re-run to be sure it isn't racy

@derrabauke
Copy link
Contributor Author

@hairmare
Copy link
Contributor

@hairmare Let's put the timed-frontend image on ghcr.io too. Any objections?

not at all, i approved you gh actions PR

@derrabauke derrabauke force-pushed the chore-timed-frontend-upgrade branch from 1fff363 to 333b490 Compare January 24, 2023 16:11
@hairmare
Copy link
Contributor

@derrabauke looks like it didn't push a tagged image because the tag already existed, easiest way forward is probably to tag another release so gh actions can do it's thing

@derrabauke
Copy link
Contributor Author

@derrabauke looks like it didn't push a tagged image because the tag already existed, easiest way forward is probably to tag another release so gh actions can do it's thing

Thanks again for helping me with this struggle. ;) Will push another tag.

@derrabauke derrabauke force-pushed the chore-timed-frontend-upgrade branch from 333b490 to c2f4590 Compare January 24, 2023 16:27
@derrabauke derrabauke marked this pull request as ready for review January 24, 2023 16:33
@derrabauke derrabauke requested a review from a team as a code owner January 24, 2023 16:33
Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

(well, with one more rebase that can be done via the gui and shouldn't need re-approval)

@derrabauke derrabauke force-pushed the chore-timed-frontend-upgrade branch from c2f4590 to 18d3971 Compare January 24, 2023 16:38
@derrabauke derrabauke merged commit 3c6430e into adfinis:main Jan 24, 2023
@derrabauke derrabauke deleted the chore-timed-frontend-upgrade branch January 24, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants