Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging-apps): Bump filebeat to 7.17 #676

Merged
merged 4 commits into from
May 3, 2022
Merged

feat(logging-apps): Bump filebeat to 7.17 #676

merged 4 commits into from
May 3, 2022

Conversation

isantospardo
Copy link
Contributor

@isantospardo isantospardo commented Apr 28, 2022 •
edited by hairmare
Loading

Description

Update filebeat to 7.17.*

Changes

FFI: https://github.com/elastic/helm-charts/blob/main/CHANGELOG.md

Closes #664

Issues

n/a

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2022
@isantospardo isantospardo marked this pull request as ready for review April 28, 2022 09:25
@isantospardo isantospardo requested a review from a team as a code owner April 28, 2022 09:25
@isantospardo isantospardo requested review from inisitijitty and tongpu and removed request for a team April 28, 2022 09:25
hairmare
hairmare requested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description seems to link to metricbeat and the warning about helm upgrade --force failing also seems to be metricbeat specific. can you clarify this in the description?

@isantospardo
Copy link
Contributor Author

The description seems to link to metricbeat and the warning about helm upgrade --force failing also seems to be metricbeat specific. can you clarify this in the description?

I have added it to the description of the issue, thanks for saying :)

@isantospardo isantospardo requested a review from hairmare May 3, 2022 08:52
@isantospardo isantospardo enabled auto-merge (squash) May 3, 2022 08:54
@hairmare
Copy link
Contributor

hairmare commented May 3, 2022

I have added it to the description of the issue, thanks for saying :)

Thanks. I'm still a bit confused 😕 Do the metricbeat chart changes affect this PR? If not, please remove them from the description, or, explain why they do affect us when we update the filebeat chart.

@isantospardo
Copy link
Contributor Author

I have added it to the description of the issue, thanks for saying :)

Thanks. I'm still a bit confused confused Do the metricbeat chart changes affect this PR? If not, please remove them from the description, or, explain why they do affect us when we update the filebeat chart.

Totally right, it only affects metricbeat, so nothing to do with filebeat, just removed the issue in the description

@isantospardo isantospardo requested a review from tongpu May 3, 2022 09:15
@isantospardo isantospardo merged commit 190d60b into main May 3, 2022
@isantospardo isantospardo deleted the feat/filebeat-7.17 branch May 3, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairmare hairmare hairmare approved these changes

@inisitijitty inisitijitty Awaiting requested review from inisitijitty inisitijitty is a code owner automatically assigned from adfinis/helm-charts

@tongpu tongpu Awaiting requested review from tongpu

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 7.17.3 of filebeat is available!
3 participants
@isantospardo @hairmare @tongpu