Remove support for non-standard module field in package.json
#2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes support for non-standard `"module"` field in `package.json`. Purpose of this field was to implement support for ES modules in its early days. This used to be a common way how to do it in bundlers, see: - Webpack: https://webpack.js.org/guides/author-libraries/#final-steps - Rollup: https://github.com/rollup/rollup/wiki/pkg.module - https://stackoverflow.com/questions/42708484/what-is-the-module-package-json-field-for However, seems like the whole system around ES modules evolved a bit differently (top level field `"type": "module"` + field `"exports"`), see: - https://nodejs.org/api/packages.html - https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c - https://babeljs.io/blog/2021/02/22/7.13.0#automatic-es-modules-in-babelruntime-12632httpsgithubcombabelbabelpull12632 This change is essentially a cleanup of our quirky and non-standard solution in order to be able to implement this modern approach.
michalsanger
approved these changes
May 5, 2021
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes support for non-standard
"module"field inpackage.json. Purpose of this field was to implement support for ES modules in its early days. This used to be a common way how to do it in bundlers, see:However, seems like the whole system around ES modules evolved a bit differently (top level field
"type": "module"+ field"exports"), see:This change is essentially a cleanup of our quirky and non-standard solution in order to be able to implement this modern approach.