-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only the part after the last advertisement is played. #8
Comments
I noticed the same thing, need to look into the streams. We need to log more information to make that easier (not just for us, but also for users to troubleshoot and fix things for us). It appears Kids shows are not affected, as well as possibly TV shows with short episodes (less than 20 minutes?). |
I've troubleshooted this a bit further. It seems that the dash manifest that anvato returns has multiple The big issue is that inputstream.adaptive doesn't seem to support Periods, and according to their README.md, they only play the first Period, but I guess they are currently playing the last one. This is probably the reason why the last part of the program is playing and I guess this is also why the full stream length is unknown. |
I've opened xbmc/inputstream.adaptive#287 for this. |
While trying some other episodes. The last episode of Married with children (S09E22) plays fine. Starts with the intro, subtitles play fine. And for some reason it lists 2 subtitles, one selected by default with a unique name, and then Dutch (I guess this was added using addStreamInfo()). Some other episodes play nice as well (some have subtitles integrated in the stream, i.e. S09E21 was cut from CAZ). But from the same season there are episodes that have the same issue. It is weird that in a single season you have a myriad of streams. |
The manifest of "Married with children (S09E22)" seems to contain an embedded dutch subtitle (that's what kodi detects), but it seems it have no content. The VTT seems to be fine however. I'm not sure why it plays at the beginning, since it also seems to contain Periods. |
Look at the Period duration, inputstream.adaptive always plays the last period. For Married with children (S09E22) the last Period is 22 minutes, the duration of a full episode. First and second period is 10 seconds and 3 seconds long. This is a Coca-Cola commercial and a VTM GO banner. |
Okay. Makes sense. I'm also wondering how this should be handled. Should all periods be merged into one stream? I assume the vtt subtitle position is depending on the episode, and the duration of the ads aren't taken into account in the subtitle timings. |
For the end user it should look like one continuous stream, so all periods should be played in succession. You can find more info about Periods is in the DASH-IF guidelines: https://dashif.org/guidelines/ Currently, I have no clue how to implement this in inputstream.adaptive. |
You are right. The VTM GO app probably knows what periods contain the real episode, and adapts the timing of the subtitle to this. We should probably rewrite the vtt ourselves based on the cues. |
Trying to understand this blocking issue:
|
Yes. vtmvod.txt
Yes, each individual Representation in a Period has a ContentProtection tag
This can only be done in InputStream Adaptive add-on because all video and audio streams are segmented and each individual segment is encrypted: xbmc/inputstream.adaptive#287 |
With the latest master branch of inputstream.adaptive everything in VTM GO plays fine, including the commercials. The known issues at this point are:
So very good news. I think we are very close to releasing VTM GO when the new inputstream.adaptive hits all Kodi 18 platforms, even with the above shortcomings. |
I agree. Subtitles is not critical to block the first release. |
Only blocker is Linux/arm support at the moment. (LibreELEC and others) |
I tried this on windows x64 with the latest kodi 19 and inputstream.adaptive 2.5.0 and I still doesn't start from the beginning... |
@peno64 The fix is not yet released and is only available from the master branch: https://jenkins.kodi.tv/blue/organizations/jenkins/peak3d%2Finputstream.adaptive/detail/master/110/artifacts |
@mediaminister hm, that is a 2.4.0 version and I already have a 2.5.0 version installed. I will wait until it is officially released... |
@peno64 I agree it is pretty confusing that the automated builds have a lower version than what is available on your system. On LibreELEC we still have inputstream.adaptive 2.3.22. We are still waiting for VRT NU on a release for something that was fixed 4 months ago... |
Totday an update of inputstream.adpative was released on the raspberry pi. It is now version 2.4.2.1. I also installed the latest vtm go plugin from release (plugin.video.vtm.go-0.9.0-master-05ebfc8.zip). But still it does not start from the beginning. The subtitles start from the beginning, but the movie not... |
Or is the 2.5 version of inputstream adaptive needed for this to work? |
The fix is not yet released for RPi, you have to build the inputstream adaptive master branch yourself to make it work! If you can't build this yourself, there are compiled versions available for a limited set of platforms at https://jenkins.kodi.tv/blue/organizations/jenkins/peak3d%2Finputstream.adaptive/detail/master/112/artifacts |
Unfortunately the jenkins site does not have a rpi version. |
Okay, it seems rather easy to cross compile this from a Linux pc. You need Raspberry Pi tools and firmware: https://github.com/xbmc/xbmc/blob/master/docs/README.RaspberryPi.md And this are standard instructions to compile Inputstream Adaptive for Kodi 18 Leia:
I will try this myself and come up with detailed instructions and a test zip for RPi if this works out. |
@mediaminister |
So I tried this again. When I just play something, for example I Frankenstein, then it starts with a commercial and then it shows a VTM Go advertise and then it wants to play the movie but after a couple of seconds it restarts and plays the commercial again and so on and on. |
Ok, so I tried this with the series "locked up". Same scenario. It starts with a commercial and then when the movie starts it restarts. But if i pause for a couple of seconds and then continue it starts to play and then I let it play until the commercial and after the commercial it just continues to play. |
@peno64 on Windows and Linux x64, it seems to work fine. I haven't tested yet on arm. |
I compiled the latest inputstream.adaptive for libreelec on raspberry pi myself. Note that this version is 2.4.0 And believe me, that is the latest version. So make sure that your addons aren't updated automatically or it will be overwritten by an auto update of the kodi addons |
I've bundled all inputstream.adaptive issues that are already fixed upstream, but not yet released in issue #101. |
Some programs like "Wat Als?" season 3, don't start in the beginning, but it seems like they start from the point after the first commercial break.
The text was updated successfully, but these errors were encountered: