-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This addon needs an updated inputstream.adaptive #101
Comments
To build inputstream adaptive for raspberry pi yourself, the following instructions are more complete and don't require to build in your home folder but in any location. This is done on a raspbian os on the pi. sudo apt install autoconf bison build-essential curl default-jdk gawk git gperf libcurl4-openssl-dev zlib1g-dev cmake zip cd folder # folder where you want to build everything git clone https://github.com/raspberrypi/tools --depth=1 git clone -b Leia https://github.com/xbmc/xbmc.git This will create inputstream.adaptive.zip in the /tmp folder |
Thanks @peno64. I've updated the README for this. |
After reinstalling OSMC's October update the plugin crashes Kodi when starting a live stream. I guess this is input stream.adaptive related. I tried recompiling it but still the same issue ... Any ideas ? |
In case you have a Vero4K+, my instructions were incomplete. Like this:
|
Thinking about it, this is probably valid for all OSMC installs, not just the ones on the Vero4K+. OSMC packages See this output:
|
ok, works again, thanks !! |
We could use a new set of builds of inputstream.adaptive for Kodi v18. |
@dagwieers |
I've rebuild a version based on xbmc/inputstream.adaptive@cc6e32d for osmc. I've changed the version so it's 2.5.3.1 (latest release is 2.5.3 (for Matrix), but this includes an additional fix we need). |
I would love a release for Leia with the current code from master. |
Because it takes time, and time is currently something I have not much left. Which things should be backported to Leia branch? |
Especially because the latest Leia version 18.5 is said to be the last version of version 18 so I guess version 18 will now remain quite stable for several months |
We produce still Leia nightlies, and I would bet that there will be a 18.6 coming. |
I understand completely. What I need for this project is the Period implementations (and your related fixes). I just tried to merge master into Leia, and there are no conflicts besides the travis and appveyor files. It's hard for users to compile their own inputstream.adaptive, but if a new release for Leia is made, all other build scripts should pick this up, and after a while, all installations should be upgraded to the updated version. I haven't fully tested inputstream adaptive for other services (YouTube, Netflix, ...) so that might need some more testing. |
That's possible, but the Leia branch (and so the nighlies also) doesn't contain all the required Period fixes if I remember correctly. |
Yes, but there are a few other things we wanted to backport, the changes in kodi are not that much, let me see |
Cool, thanks! I basicly want a user to be able to install this addon on the latest stable Kodi (18), without having to update his inputstream adaptive manually. |
@peak3d It is the only thing preventing us from pushing the VTM GO add-on to the Kodi repository. Thanks for all your help. Let us know if we can help in any way. |
BTW I have been testing @peno64's Leia build for RPi since he offered it (6 weeks), using Youtube and Netflix frequently, so I am confident this works fine. |
I think my build isn't completely okay. I've tried building the Leia branch of IA for osmc, and there I also have issues with the Netflix addon, while vtm go is okay, so it's something with my build. |
@peak3d While you're at it, we have a subtitle-fix we would like to see backported to the Leia branch as well. See: add-ons/plugin.video.vrt.nu#45 PS Beware that this issue tracked two issues, the first one was fixed in the Leia branch IIRC, but the second issue was only released in the Matrix branch. Update: This was requested in issue xbmc/inputstream.adaptive#330 |
For users on OSMC on a Vero4K+, unzip this file and overwrite it in This build supports periods, and doesn't break netflix. |
Anybody has a link to a build for windows? Seems like the links in the https://github.com/michaelarnauts/plugin.video.vtm.go/wiki/Inputstream-Adaptive are down. |
@michaelarnauts |
@KBET80 |
I called out to all stakeholders for testing the upcoming v2.4.3 on Leia at xbmc/inputstream.adaptive#387 |
@michaelarnauts It may be useful to open the Wiki for specific users (e.g. @peno64) or open it up to the public (it is a Git repository after all, so data loss is not an issue). |
@dagwieers I've opened up this wiki. The inputstream page is quite outdated anyway, since the existing links don't seem to work anymore. |
@michaelarnauts Maybe you ought to move working copies from Jenkins into the releases/downloads section of your latest release before they get lost? I don't mind doing that if you give me those privileges. |
Inputstream Adaptive 2.4.3 is released for Leia! https://github.com/peak3d/inputstream.adaptive/releases/tag/2.4.3-Leia This means that in the course of the next days, you will get an updated Inputstream Adaptive! Platform overview:
|
OSX also has an official update. We expect an update for LibreELEC in the coming days: LibreELEC/LibreELEC.tv#4226 And there is an overview of the platforms that are already having this update: |
All platforms (except OSMC) currently have an updated inputstream.adaptive v2.4.3 so I think we can close this issue now. |
I want to add a dependency on Inputstream Adaptive 2.4.3 in the addon.xml to enforce users to have at least this version. |
I've added the dependency, and I'm waiting until the release is accepted in the Kodi repository before tagging 1.0. |
@peno64 Could you please explain the equivalent of the same steps here for compiling inputstream adaptive for windows 32bit on windows 10 32bit? Which software I will need for compiling inputstream adaptive on windows 10 32bit? I need to modify inputstream adaptive from Leia branch to fix a problem in the subtitle in my language with Kodi and it could be fixed using inputstream adaptive and to compile it for windows 32bit, and not sure if requesting adding this fix to the official inpustream adaptive is ok since the problem is originally in Kodi, and in Kodi I did not get any response for fixing it after opening an issue there, thanks. https://github.com/michaelarnauts/plugin.video.vtm.go/issues/101#issuecomment-541317533 I need to compile this branch for inputstream adaptive to work with Kodi 18.6 windows 32bit. https://github.com/Essam311/inputstream.adaptive/tree/diacritical-marks |
@Essam311 I have no idea how it's done on Windows. For sure completely different. Jenkins is your best option here. But are you sure that you need another compilation for kodi 18.6? |
@peno64 OK, thank you, yes I need to compile this branch which has fix for a problem with the subtitle in my language with Kodi. https://github.com/Essam311/inputstream.adaptive/tree/diacritical-marks This problem. |
@peno64 Is it possible to modify my fork from inpustream adaptive so Jenkins compile the files when I make a PR? |
@Essam311 But is this change also in the Lea branch of inputstream.adaptive or only in master? If only in master then it will not work. Master is for the new kodi 19 (Matrix) |
@Essam311 So what I actually mean is is the diacritical-marks branch a branch originally from master or from Leia_backport? |
@Essam311 Probably the Leia branch is also a good starting point as I see now it was also updated |
@Essam311 I found this: xbmc/inputstream.adaptive#18 and there it says at the end: "build instructions are inside kodi/docs/README.xxx files" |
@peno64 Thank you. |
In an attempt to clean up the issues a bit, I will create this meta-issue that is tracking the release of
inputstream.adaptive
for Kodi 18.Without this update, this will have many issues related to playback of Live TV and VOD (https://github.com/michaelarnauts/plugin.video.vtm.go/issues/1, https://github.com/michaelarnauts/plugin.video.vtm.go/issues/8, https://github.com/michaelarnauts/plugin.video.vtm.go/issues/28).
The README.md contains more information on how to get an updated
inputstream.adaptive
.The text was updated successfully, but these errors were encountered: