feat(calendar): ✨ version 1 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navin-moorthy
added
component ⚙️
navin-moorthy
changed the title
|
Deploy preview for renderless-components ready! Built with commit 9e5fb3e https://deploy-preview-51--renderless-components.netlify.app |
This was referenced Sep 21, 2020
Closed
anuraghazra
reviewed
Sep 21, 2020
anuraghazra
reviewed
Sep 21, 2020
anuraghazra
reviewed
Sep 21, 2020
anuraghazra
reviewed
Sep 21, 2020
* fix: calender state keys * feat: added CalendarHeader component * chore: improved ts types for calendar * refactor: removed unused type & reexported components * feat: added Calendar base component and aria-labeledby * chore: review updates
feat: return daysOfMonths to map easily
* fix: calender state keys * feat: added CalendarHeader component * chore: improved ts types for calendar * refactor: removed unused type & reexported components * feat: added Calendar base component and aria-labeledby * chore: review updates * style: added new styles & data-weekend prop * chore: removed unused function
navin-moorthy
changed the title
anuraghazra
reviewed
Sep 22, 2020
anuraghazra
reviewed
Sep 22, 2020
|
LGTM! |
navin-moorthy
commented
Sep 22, 2020
| @@ -24,7 +24,7 @@ export const useCalendarWeekTitle = createHook< | |||
|
|
|||
| useProps({ dayIndex, weekDays }, htmlProps) { | |||
| return { | |||
| "aria-label": weekDays[dayIndex].title, | |||
| "aria-label": weekDays[dayIndex]?.title, | |||
There was a problem hiding this comment.
Dang 💢
I miss this everytime 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.