Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add variable for .on-screen-anim() mixin's transition-delay (fixes #416) #417

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Fix: Add variable for .on-screen-anim() mixin's transition-delay (fixes #416) #417

merged 1 commit into from
Apr 17, 2023

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Apr 6, 2023 •
edited
Loading

Fixes #416

Fix

  • Adds @animation-delay and sets the default to 1s.
  • Use this new variable in the four default .on-screen-anim() calls.

@swashbuck swashbuck self-assigned this Apr 6, 2023
@swashbuck swashbuck requested a review from kirsty-hames April 6, 2023 17:19
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@kirsty-hames kirsty-hames merged commit ca68ffd into master Apr 17, 2023
@kirsty-hames kirsty-hames deleted the issue/416 branch April 17, 2023 08:42
@github-actions
Copy link

🎉 This PR is included in version 9.6.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@chucklorenz chucklorenz Awaiting requested review from chucklorenz

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add variable for .on-screen-anim() mixin's transition-delay
4 participants
@swashbuck @kirsty-hames @guywillis @cahirodoherty-learningpool