-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to disable popup and show error inline #12
Comments
Can you explain how you expect the reading and focus order to run? |
One idea would be to keep the focus on the button that's announced as dimmed/disabled. Then, have the aria-live region read the instruction text? That way, the user doesn't lose their place in the flow. |
Could you mock it up and give it to Kirsty to test and critique? Personally, I think going back to the proposed style, which is what we had before the button was disabled permanently, is really not a great idea. Why do you think it would be a good idea? Concerns: Red will not be enough for the instruction text, it will also need to be emboldened I imagine. You'll need to think about the pros and cons for each user group, sighted users will not see off screen instruction text for a long question component on a short screen, etc etc You'll need to think about how to update the styling and icon without editing the DOM directly but instead using the model and react template. It should probably be part of instructionError rather than a core change so that we can test it out properly. |
🎉 This issue has been resolved in version 2.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Subject of the enhancement
It would be useful to have an alternate way to present the instruction error. Instead of a Notify popup, the instruction text could be highlighted with an icon / color and an assertive
aria-live
announcement could be made. An option like_showErrorInline
or_disablePopup
could handle this.Interestingly, there is already an
.icon
element inside of.component__instruction
that could be used to show an error icon.Your environment
Screenshots
The text was updated successfully, but these errors were encountered: