Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#232 Resolves Add completion statuses when using tile layout #233

Merged
merged 4 commits into from
Jul 26, 2022
Merged

#232 Resolves Add completion statuses when using tile layout #233

merged 4 commits into from
Jul 26, 2022

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Jun 29, 2022 •
edited
Loading

Resolves #232

Adds a checkmark icon when the item has been visited.

hotgraphic-tile-visited

Better styling to be added to the theme: adaptlearning/adapt-contrib-vanilla#335

@swashbuck swashbuck mentioned this pull request Jun 29, 2022
Closed
@swashbuck swashbuck mentioned this pull request Jun 29, 2022
Merged
guywillis
guywillis reviewed Jul 4, 2022
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the nesting from the selectors please

@swashbuck
Copy link
Contributor Author

remove the nesting from the selectors

Done.

joe-allen-89
joe-allen-89 approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with FW v5.20.0, working as expected.

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 4c50cab into adaptlearning:master Jul 26, 2022
github-actions bot pushed a commit that referenced this pull request Jul 26, 2022
@semantic-release-bot
Chore(release): 6.3.0 [skip ci]
60c0b31 
# [6.3.0](v6.2.1...v6.3.0) (2022-07-26)

### New

* Add completion ticks in tile layout (#233) ([4c50cab](4c50cab)), closes [#233](#233)
@github-actions
Copy link

🎉 This PR is included in version 6.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@swashbuck swashbuck

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add completion statuses when using tile layout
6 participants
@swashbuck @guywillis @cahirodoherty-learningpool @eleanor-heath @joe-allen-89 @oliverfoster