Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: set html lang and dir attributes from config.json (fixes #499) #500

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix: set html lang and dir attributes from config.json (fixes #499) #500

merged 1 commit into from
Feb 12, 2024

Conversation

oliverfoster
Copy link
Member

fixes #499

Fix

  • Set initial html lang and dir attributes from _defaultLanguage and _defaultDirection in config.json

@oliverfoster oliverfoster self-assigned this Feb 12, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 6010954 into master Feb 12, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/499 branch February 12, 2024 16:13
github-actions bot pushed a commit that referenced this pull request Feb 12, 2024
@semantic-release-bot
Chore(release): 6.45.5
e218075 
## [6.45.5](v6.45.4...v6.45.5) (2024-02-12)

### Fix

* set html lang and dir attributes from config.json (fixes 499) (#500) ([6010954](6010954)), closes [#500](#500)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.45.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanlavenius johanlavenius johanlavenius approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@lemmyadams lemmyadams lemmyadams approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting language of course for Google Translate
4 participants
@oliverfoster @johanlavenius @cahirodoherty-learningpool @lemmyadams