Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Reset and show only incorrect questions #185

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jun 1, 2023

fixes #184

Fix

  • Reset and show only incorrect questions

Notes

  • The pass mark is relative to the questions in the attempt only

@simondate simondate self-requested a review November 17, 2023 14:40
@simondate simondate marked this pull request as ready for review November 17, 2023 14:40
Copy link
Member

@simondate simondate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working correctly.

I'm just curious why you designed it this way. I would have imagined this feature would have been implemented in a way where the correctly answered remain but are shown as already answered correctly.

It feels a bit odd to have the new pass mark be calculated without having the original correctly answered questions included.

@oliverfoster
Copy link
Member Author

@simondate fair point.

It was only a draft idea at the time of creation. No real design thinking involved. You're more than welcome to update it to accommodate if you like?

I'm not entirely sure how you'd do it, I'd think you'd probably want the correctly answered questions at the top of the assessment and the incorrectly unanswered ones at the bottom? Thinking about trickle and Question Title Numbering you might have some interesting use-cases to consider.

These lines could easily become a sort rather than a removal https://github.com/adaptlearning/adapt-contrib-assessment/pull/185/files#diff-68807b2fce6e8390935769013dfb667988bb81f392cac911ba435b21e5d77149R522-R526

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@simondate
Copy link
Member

simondate commented Nov 24, 2023

@simondate fair point.

It was only a draft idea at the time of creation. No real design thinking involved. You're more than welcome to update it to accommodate if you like?

I'm not entirely sure how you'd do it, I'd think you'd probably want the correctly answered questions at the top of the assessment and the incorrectly unanswered ones at the bottom? Thinking about trickle and Question Title Numbering you might have some interesting use-cases to consider.

These lines could easily become a sort rather than a removal https://github.com/adaptlearning/adapt-contrib-assessment/pull/185/files#diff-68807b2fce6e8390935769013dfb667988bb81f392cac911ba435b21e5d77149R522-R526

@oliverfoster I'm sure there would be other edge cases too like question banks, although come to think of it they would have affected the current PR too.

I'm happy to leave this as is to get it merged.

@oliverfoster oliverfoster merged commit 69a43e5 into master Apr 8, 2024
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
# [5.2.0](v5.1.11...v5.2.0) (2024-04-08)

### New

* Reset and show only incorrect questions (#185) ([69a43e5](69a43e5)), closes [#185](#185)
@oliverfoster oliverfoster deleted the issue/184 branch April 8, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset and show only failed questions
4 participants