-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Reset and show only incorrect questions #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working correctly.
I'm just curious why you designed it this way. I would have imagined this feature would have been implemented in a way where the correctly answered remain but are shown as already answered correctly.
It feels a bit odd to have the new pass mark be calculated without having the original correctly answered questions included.
@simondate fair point. It was only a draft idea at the time of creation. No real design thinking involved. You're more than welcome to update it to accommodate if you like? I'm not entirely sure how you'd do it, I'd think you'd probably want the correctly answered questions at the top of the assessment and the incorrectly unanswered ones at the bottom? Thinking about trickle and Question Title Numbering you might have some interesting use-cases to consider. These lines could easily become a sort rather than a removal https://github.com/adaptlearning/adapt-contrib-assessment/pull/185/files#diff-68807b2fce6e8390935769013dfb667988bb81f392cac911ba435b21e5d77149R522-R526 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
@oliverfoster I'm sure there would be other edge cases too like question banks, although come to think of it they would have affected the current PR too. I'm happy to leave this as is to get it merged. |
fixes #184
Fix
Notes