Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _ariaLevel override property #142

Closed
kirsty-hames opened this issue Oct 30, 2023 · 1 comment · Fixed by #143
Closed

Remove _ariaLevel override property #142

kirsty-hames opened this issue Oct 30, 2023 · 1 comment · Fixed by #143
Assignees
@kirsty-hames
Labels
accessibility released

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

As per Core issue, since _ariaLevels were automated in Core, there's no need to manually override these now.

Expected behaviour

Item title aria-level should inherit from componentItem and override: _ariaLevel ?? itemAriaLevel can be removed.
@kirsty-hames kirsty-hames self-assigned this Oct 30, 2023
@kirsty-hames kirsty-hames moved this from New to Assigned in adapt_framework: The TODO Board Oct 30, 2023
@kirsty-hames kirsty-hames mentioned this issue Oct 30, 2023
Merged
@kirsty-hames kirsty-hames moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Oct 30, 2023
kirsty-hames added a commit that referenced this issue Nov 13, 2023
@kirsty-hames
Update: Remove _ariaLevel override property (fixes #142) (#143)
c6d405c
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Nov 13, 2023
github-actions bot pushed a commit that referenced this issue Nov 13, 2023
@semantic-release-bot
Chore(release): 7.5.0 [skip ci]
78ff072 
# [7.5.0](v7.4.3...v7.5.0) (2023-11-13)

### Update

* Remove _ariaLevel override property (fixes #142) (#143) ([c6d405c](c6d405c)), closes [#142](#142) [#143](#143)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: Remove _ariaLevel override property (fixes #142) adaptlearning/adapt-contrib-accordion
1 participant
@kirsty-hames