Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing semantic differentiation between status and heading #118

Closed
swashbuck opened this issue Jun 30, 2022 · 1 comment · Fixed by #119
Closed

Missing semantic differentiation between status and heading #118

swashbuck opened this issue Jun 30, 2022 · 1 comment · Fixed by #119
Assignees
@swashbuck
Labels
accessibility bug released

Comments

@swashbuck
Copy link
Contributor

Bug Description:

After an accordion item has been visited, "visited" text is included in the item title without semantic differentiation. This can render understanding of the item title unclear for screen reader users.

Expected Behavior:

  • Update the accordion label to include its updated state after it has been visited (ex: Lists (visited))
  • Add a checkmark icon to visually indicate the updated state of the item.
@swashbuck swashbuck self-assigned this Jun 30, 2022
@swashbuck swashbuck mentioned this issue Jul 5, 2022
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jul 19, 2022
oliverfoster pushed a commit that referenced this issue Jul 24, 2022
@swashbuck
Fix: Improved accessibility, added checkmark (fixes #118) (#119)
6bb82e8 
* #118 Switch to 'visited' status instead of 'complete/incomplete'. Move 'visited' status after item title and wrap in parentheses.

* #118 Change icon to checkmark once visited

* #118 Change conditional method to avoid outputting 'false'

* 118 Revert

Switch aria-label to visited status instead of complete/incomplete.
Move visited status after item title and wrap in parentheses when it exists.

Then, add period after status.

* #118 Change item status label to visited instead of complete/incomplete
Repository owner moved this from Needs Reviewing to Needs Releasing in adapt_framework: The TODO Board Jul 24, 2022
github-actions bot pushed a commit that referenced this issue Jul 24, 2022
@semantic-release-bot
Chore(release): 7.2.1 [skip ci]
fe56c2a 
## [7.2.1](v7.2.0...v7.2.1) (2022-07-24)

### Fix

* Improved accessibility, added checkmark (fixes #118) (#119) ([6bb82e8](6bb82e8)), closes [#118](#118) [#119](#119) [#118](#118) [#118](#118) [#118](#118) [#118](#118)
@github-actions
Copy link

🎉 This issue has been resolved in version 7.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to deltanet/adapt-contrib-accordion-audio that referenced this issue Aug 18, 2022
@semantic-release-bot
Chore(release): 4.3.0 [skip ci]
20e58d8 
# [4.3.0](v4.2.0...v4.3.0) (2022-08-18)

### chore

* added package.json ([5c04e24](5c04e24))
* added package.json ([7feeca5](7feeca5)), closes [#3072](https://github.com/deltanet/adapt-contrib-accordion-audio/issues/3072)

### Fix

* Added gitignore for release automation (adaptlearning#124) ([4d08acd](4d08acd)), closes [adaptlearning#124](https://github.com/deltanet/adapt-contrib-accordion-audio/issues/124)
* Added package-lock.json (adaptlearning#123) ([70465a1](70465a1)), closes [adaptlearning#123](https://github.com/deltanet/adapt-contrib-accordion-audio/issues/123)
* Added release automation (adaptlearning#122) ([3dbefe6](3dbefe6)), closes [adaptlearning#122](https://github.com/deltanet/adapt-contrib-accordion-audio/issues/122)
* Improved accessibility, added checkmark (fixes adaptlearning#118) (adaptlearning#119) ([6bb82e8](6bb82e8)), closes [adaptlearning#118](https://github.com/deltanet/adapt-contrib-accordion-audio/issues/118) [adaptlearning#119](https://github.com/deltanet/adapt-contrib-accordion-audio/issues/119) [adaptlearning#118](https://github.com/deltanet/adapt-contrib-accordion-audio/issues/118) [adaptlearning#118](https://github.com/deltanet/adapt-contrib-accordion-audio/issues/118) [adaptlearning#118](https://github.com/deltanet/adapt-contrib-accordion-audio/issues/118) [adaptlearning#118](https://github.com/deltanet/adapt-contrib-accordion-audio/issues/118)

### New

* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) (adaptlearning#121) ([ce0888f](ce0888f)), closes [adaptlearning#121](https://github.com/deltanet/adapt-contrib-accordion-audio/issues/121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Missing semantic differentiation between status and heading
2 participants
@swashbuck @oliverfoster