first tag with a given version is not used #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamralph
changed the title
adamralph
changed the title
adamralph
changed the title
|
release in 2.3.1-beta.2 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s)
2.3.0To reproduce
Run MinVer against a repo which looks like ☝️.
Expected behaviour
The tag on the first (blue) branch is used, since that branch was the current branch when the merged was performed. The version is
1.0.0-alpha.2.Actual behaviour
The tag on the second (yellow) branch is used. The version is
1.0.0-alpha.1.Workarounds
Tag some commit to coerce the version into being something you expect.
Additional context
Found while fixing #377. Thanks again to @karlika for spotting that bug!
Another approach is to ignore the
1.0.00tag, since it is not valid SemVer due to the leading zero in the patch version. However, there may be other cases where the two tags could produce the same version, e.g. using special chars, so it's probably better to just assume that it is possible for two tags to produce the same version.