Fixed the creation of groups with invalid characters (fixes #120) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Ansible 2.8 dots (.) are no longer allowed in ansible groups: https://docs.ansible.com/ansible/latest/reference_appendices/config.html#transform-invalid-group-chars. This patch fixes that problem by renaming host counts to use `_<count>` instead of `.<count>`. Tests were fixed (and passes) but fixtures/ were left untouched.
|
Hrm, this is going to break some people's playbooks. I suppose it can't be avoided, though, so we'll just have to mention it in the release notes. It's not hard to update a playbook, so not worth putting it behind a flag. Thanks very much for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Ansible 2.8 dots (.) are no longer allowed in ansible groups: https://docs.ansible.com/ansible/latest/reference_appendices/config.html#transform-invalid-group-chars.
This patch fixes that problem by renaming host counts to use
_<count>instead of.<count>.Tests were fixed (and passes) but fixtures/ were left untouched.