Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confused nuget references #2

Closed
sawilde opened this issue Aug 7, 2013 · 5 comments
Closed

confused nuget references #2

sawilde opened this issue Aug 7, 2013 · 5 comments

Comments

@sawilde
Copy link
Contributor

sawilde commented Aug 7, 2013

I am developing a 'portable' nuget package that references the sharpcompress library however I am having issues when I use my package on .NET40.

My assembly is referencing the sharpcompress.portable assembly but in a .NET40 project the sharpcompress.dll is loaded instead causing a missing reference exception. Manually changing the reference works but is definitely confusing.

Would it be possible to have all your assemblies be called SharpCompress.dll when they are packaged into the nuget package?
sawilde pushed a commit to sawilde/sharpcompress that referenced this issue Aug 8, 2013
Ensure the assemblies have the same name in the nuget package adamhat…
2dc2973 
…hcock#2
@adamhathcock
Copy link
Owner

No problem. I'll release again after I can merge the pull request. Thanks!

@sawilde
Copy link
Contributor Author

sawilde commented Aug 12, 2013

Okay I'll update my nuget package to reference your new one once this is done. Can't wait.

@adamhathcock
Copy link
Owner

Cool. Just let me know when.

@sawilde
Copy link
Contributor Author

sawilde commented Aug 13, 2013

After you've published your nuget package so I can reference the version number.

From: Adam Hathcockmailto:[email protected]
Sent: ‎13/‎08/‎2013 8:25 PM
To: adamhathcock/sharpcompressmailto:[email protected]
Cc: Shaun Wildemailto:[email protected]
Subject: Re: [sharpcompress] confused nuget references (#2)

Cool. Just let me know when.

Reply to this email directly or view it on GitHub:
#2 (comment)

@sawilde sawilde mentioned this issue Aug 13, 2013
Closed
adamhathcock added a commit that referenced this issue Aug 13, 2013
@adamhathcock
Merge pull request #4 from sawilde/master
718dac1 
Ensure the assemblies have the same name in the nuget package #2
@adamhathcock
Copy link
Owner

Released 0.10.1.1...hopefully this behaves better for you.

norvegec referenced this issue in KOLANICH-libs/sharpcompress May 17, 2015
@KOLANICH
Improved testability
b9d33ff 
1) disabled requirement of signature
2) added runtime discovery of folder with archives

changes by this commit are already present in 13ef1c3
@coderb coderb mentioned this issue Dec 17, 2017
Merged
adamhathcock pushed a commit that referenced this issue Jun 4, 2021
@Artentus
Merge pull request #2 from adamhathcock/master
d5e6c31 
Merge master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sawilde @adamhathcock