Fix Content-Length header to count bytes (#143)

Co-authored-by: Adam Johnson <[email protected]>
adamchainz · Sep 4, 2023 · af8f45f · af8f45f
1 parent 6803307
commit af8f45f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -2,6 +2,10 @@
 Changelog
 =========
 
+* Fix the value in the ``Content-Length`` header to correctly count bytes, rather than unicode characters.
+
+  Thanks to Haydn Greatnews in `PR #143 <https://github.com/adamchainz/django-minify-html/pull/143>`__.
+
 1.6.0 (2023-06-14)
 ------------------
 

diff --git a/src/django_minify_html/middleware.py b/src/django_minify_html/middleware.py
@@ -55,7 +55,7 @@ def maybe_minify(self, request: HttpRequest, response: HttpResponseBase) -> None
             minified_content = minify_html.minify(content, **self.minify_args)
             response.content = minified_content
             if "Content-Length" in response:
-                response["Content-Length"] = len(minified_content)
+                response["Content-Length"] = len(response.content)
 
     minify_args = {
         "minify_css": True,

diff --git a/tests/views.py b/tests/views.py
@@ -5,8 +5,8 @@
 
 from django_minify_html.decorators import no_html_minification
 
-basic_html = b"<!doctype html><html><body><p>Hi</p></body></html>"
-basic_html_minified = b"<!doctypehtml><body><p>Hi"
+basic_html = "<!doctype html><html><body><p>Hi 👋</p></body></html>".encode()
+basic_html_minified = "<!doctypehtml><body><p>Hi 👋".encode()
 
 
 def streaming(request):