Significant whitespace at the end of lines is being lost from Markdown

[adam-p]

According to the Markdown spec, two spaces at the end of a line indicates a hard line-break (<br>) should be inserted in the rendering.

But the original-HTML-to-plaintext module we're using strips trailing whitespace. See:
https://github.com/adam-p/markdown-here/blob/master/src/common/jsHtmlToText.js#L72

Unfortunately, there are no hooks in htmlToText that will let us skip the stripping. So we'll either have to:

• modify the code directly
  • distasteful because it makes it harder to pull in any updates to the original project
• in the preprocessing hook, replace trailing whitespace with placeholder tags, and then swap them back to the original whitespace in the tagreplacement hook
  • distasteful because it's ugly

Originally discovered by a Reddit commenter.

[adam-p]

Fixed in 49c6b61

[crdx]

distasteful because it makes it harder to pull in any updates to the original project

If you were to make your change in a fork of js-htmltotext and pull upstream and push origin whenever it was updated, wouldn't that be a reasonably easy way of maintaining this change while simultaneously keeping it up-to-date?

This is assuming your change isn't accepted in a pull request back to the original project, of course.

(I know I'm late to the party, but I thought it might be worth still mentioning.)