Fixed #288: Some character combinations involving a dollar sign in in…

…line code would render incorrectly

src/common/CHANGES.md

@@ -4,12 +4,14 @@ Change Log
 ### Voting is complete and the [**new Markdown Here logo**](http://markdown-here.com/logo.html) has been chosen by the users!
 
 
-2015-06-xx: v2.11.10
+2015-xx-yy: v2.11.10
 --------------------
 
 * [Fixed bug #283](https://github.com/adam-p/markdown-here/issues/283): Forgot-to-render detection was broken for Google Inbox. Thanks to [Marvin R.](https://github.com/therealmarv).
   - If you find that the forgot-to-render detection gets broken for the Gmail or Google Inbox web interfaces, please post to the ["markdown-here" Google Group](https://groups.google.com/group/markdown-here) or create [an issue in the Github project](https://github.com/adam-p/markdown-here/issues). The MDH code that hooks into the web UI is brittle and might break when Google changes stuff.
 
+* [Fixed bug #288](https://github.com/adam-p/markdown-here/issues/288): Some character combinations involving a dollar sign in inline code would render incorrectly. Thanks to [rfulkerson](https://github.com/rfulkerson).
+
 
 2015-05-26: v2.11.9
 -------------------

src/common/mdh-html-to-text.js

@@ -352,7 +352,12 @@ function convertHTMLtoMarkdown(tag, html) {
       });
 
     for (var i = 0; i < htmlToRestore.length; i++) {
-      html = html.replace(htmlToRestore[i][0], htmlToRestore[i][1]);
+      html = html.replace(htmlToRestore[i][0], function() {
+          // The replacement argument to `String.replace()` has some magic values: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/String/replace#Specifying_a_string_as_a_parameter
+          // Because we don't control the content of that argument, we either
+          // need to escape dollar signs in it, or use the function version.
+          return htmlToRestore[i][1];
+        });
     }
   }
   else {

src/common/test/mdh-html-to-text-test.js

@@ -169,6 +169,14 @@ describe('MdhHtmlToText', function() {
       expect(get(html)).to.equal(target);
     });
 
+    // Test the fix for bug https://github.com/adam-p/markdown-here/issues/288
+    // Use of dollar sign in inline code producing odd results
+    it('should properly handle a dollar sign in inline code', function() {
+      var html = '`$`';
+      var target = '`$`';
+      expect(get(html)).to.equal(target);
+    });
+
   });
 
   describe('MdhHtmlToText (check-for-MD mode)', function() {