Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tinyusb to fix rp2040 multiple setup #9042

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

hathach
Copy link
Member

@hathach hathach commented Mar 13, 2024

@dhalbert
Copy link
Collaborator

dhalbert commented Mar 13, 2024

@tlyu @eightycc could you test? I am not able to reproduce this reliably at all with tio and ctrl-t-q on my Mac Mini M1 with previous versions of CircuitPython: maybe once out 100 tries. (Do you have any ideas why it works better for me?)

@eightycc
Copy link

@dhalbert Getting this to reproduce reliably requires building at -Og. I think there's a timing component to the original bug. Testing it here at -Og and with the couple of RP2040 revs I have on hand is on my list for later today.

@eightycc
Copy link

eightycc commented Mar 13, 2024

Tested on MacBook Air M1 with Sonoma 14.4.

Building current CP main using -Og without this PR, tio test fails with one or two tries. All the same with this PR, I cannot get it to fail. Tested with both RP2040 B1 and B2.

Looks good to me, I'd ship it.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eightycc Thank you for testing!

@dhalbert dhalbert merged commit 9d6edc0 into adafruit:main Mar 13, 2024
493 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hard fault on serial disconnect on MacroPad RP2040
3 participants